From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: marius.cristea@microchip.com, jic23@kernel.org, lars@metafoo.de,
robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: adding MCP3564 ADC
Date: Mon, 17 Jul 2023 08:25:31 +0200 [thread overview]
Message-ID: <d0682516-28aa-dbfc-81d1-33300c669835@linaro.org> (raw)
In-Reply-To: <20230714150051.637952-2-marius.cristea@microchip.com>
On 14/07/2023 17:00, marius.cristea@microchip.com wrote:
> From: Marius Cristea <marius.cristea@microchip.com>
>
> This is the device tree schema for iio driver for
> Microchip family of 153.6 ksps, Low-Noise 16/24-Bit
...
> +
> +dependencies:
> + spi-cpol: [ spi-cpha ]
> + spi-cpha: [ spi-cpol ]
Put dependencies after patternProperties:, before required:.
> +
> +patternProperties:
> + "^channel@([0-9]|([1-7][0-9]))$":
> + $ref: adc.yaml
> + type: object
Missing unevaluatedProperties: false.
Open other bindings and look how it is done there.
> + description: Represents the external channels which are connected to the ADC.
> +
> + properties:
> + reg:
> + description: The channel number in single-ended and differential mode.
> + minimum: 0
> + maximum: 79
> +
> + diff-channels: true
Why? Drop, unless you want to say there all other ADC properties are
invalid for this type of device (device, not driver!).
> +
> + required:
> + - reg
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-17 6:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 15:00 [PATCH v2 0/2] Adding support for Microchip MCP3564 ADC family marius.cristea
2023-07-14 15:00 ` [PATCH v2 1/2] dt-bindings: iio: adc: adding MCP3564 ADC marius.cristea
2023-07-15 10:28 ` Conor Dooley
2023-07-16 15:19 ` Jonathan Cameron
2023-07-18 9:24 ` Marius.Cristea
2023-07-20 18:38 ` Jonathan Cameron
2023-07-17 6:25 ` Krzysztof Kozlowski [this message]
2023-07-19 15:40 ` Marius.Cristea
2023-07-19 17:20 ` Krzysztof Kozlowski
2023-07-14 15:00 ` [PATCH v2 2/2] iio: adc: adding support for " marius.cristea
2023-07-16 15:54 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0682516-28aa-dbfc-81d1-33300c669835@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.cristea@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).