From: Guenter Roeck <linux@roeck-us.net>
To: Stanimir Varbanov <svarbanov@suse.de>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Stefan Wahren <wahrenst@gmx.net>,
Saenz Julienne <nsaenz@kernel.org>,
Andrea della Porta <andrea.porta@suse.com>,
Phil Elwell <phil@raspberrypi.com>,
Jonathan Bell <jonathan@raspberrypi.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH 2/4] hwmon: adc: rp1: Add Raspberry Pi's RP1 ADC driver
Date: Wed, 24 Sep 2025 19:42:49 -0700 [thread overview]
Message-ID: <d07158fc-678e-4ae4-8943-168146a58fe0@roeck-us.net> (raw)
In-Reply-To: <20250925000416.2408457-3-svarbanov@suse.de>
On Thu, Sep 25, 2025 at 03:04:14AM +0300, Stanimir Varbanov wrote:
> A five-input successive-approximation analogue-to-digital converter
> with 12-bit (effective number of 9.5 bits) resolution at 500kSPS.
> The ADC has four external inputs and one internal temperature sensor.
>
> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
> Signed-off-by: Jonathan Bell <jonathan@raspberrypi.com>
> Signed-off-by: Stanimir Varbanov <svarbanov@suse.de>
I just realized that there is already a hwmon driver for
Rasperri Pi - drivers/hwmon/raspberrypi-hwmon.c.
Please add this code to that driver.
> ---
> drivers/hwmon/Kconfig | 10 ++
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/rp1-adc.c | 301 ++++++++++++++++++++++++++++++++++++++++
Also, this needs documentation.
Thanks,
Guenter
next prev parent reply other threads:[~2025-09-25 2:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 0:04 [PATCH 0/4] Add Raspberry Pi's RP1 ADC Stanimir Varbanov
2025-09-25 0:04 ` [PATCH 1/4] dt-bindings: " Stanimir Varbanov
2025-09-25 19:40 ` Conor Dooley
2025-09-25 20:37 ` Guenter Roeck
2025-09-30 10:20 ` Stanimir Varbanov
2025-09-30 10:47 ` Phil Elwell
2025-09-30 18:58 ` Conor Dooley
2025-09-25 0:04 ` [PATCH 2/4] hwmon: adc: rp1: Add Raspberry Pi's RP1 ADC driver Stanimir Varbanov
2025-09-25 0:34 ` Guenter Roeck
2025-09-25 2:42 ` Guenter Roeck [this message]
2025-09-25 5:26 ` Stefan Wahren
2025-09-25 14:34 ` Guenter Roeck
2025-09-29 21:50 ` Stanimir Varbanov
2025-09-25 0:04 ` [PATCH 3/4] arm64: dts: rp1: Add Raspberry Pi's RP1 ADC DT node Stanimir Varbanov
2025-09-25 0:04 ` [PATCH 4/4] arm64: dts: broadcom: Enable RP1 ADC for RPi5 Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d07158fc-678e-4ae4-8943-168146a58fe0@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrea.porta@suse.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=jdelvare@suse.com \
--cc=jonathan@raspberrypi.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=robh@kernel.org \
--cc=svarbanov@suse.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox