From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F30C71145 for ; Thu, 24 Aug 2023 06:48:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240184AbjHXGrs (ORCPT ); Thu, 24 Aug 2023 02:47:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240045AbjHXGrq (ORCPT ); Thu, 24 Aug 2023 02:47:46 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADDB9101 for ; Wed, 23 Aug 2023 23:47:44 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9a19bf6ab66so479258466b.3 for ; Wed, 23 Aug 2023 23:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692859663; x=1693464463; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rWyCqPmgJ3hv088pfINrZgnv5A96Iv0KRz5jP4Vn3gE=; b=Q1YxpQjwCSojzu8J7+jwEuQ5tsa8M8oZ/+fvYjx8tgyKlcSZKO1lJZAFcjvoM1qP7B YWGXCzpqecdVLPDMIfxvovI6TgUmHg+AZfaarnDtkhGHEYwHNLnZiQPOBWF/1ENdHUyQ 2XjKvZVXv1XvXbx4xN0Sf3kp6r3muB35cVXIni3qM+o/6ipGnJPvAjuDS5hnIyUFT2H7 Haq9br+D7bFShH/PrPIu2fEDb9mUcZ8dyNkEqOh4iV+91xcMzLkMqboRXHt/5e3N02la rpcHvpTLkZ32A48bPvzRmY+eqQFr4wGLscI2XdERPtvtRaIGrefupRoFbjFpxborNAN/ P2jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692859663; x=1693464463; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rWyCqPmgJ3hv088pfINrZgnv5A96Iv0KRz5jP4Vn3gE=; b=UXZZxGVIfcTKfsA3G81K1ihhc36B/iPLPeCq6IquspCmaoyFElIO3AMyYCZshdepua cwtN4PN8ff6BIrfr5nAyGelWZimXSf+CjLIW9qBlQLJV4MN46Wci4lVBRRNzlKtHPQPP X7GtLHz609X11lp2Ywrt+9qjbe79pXcheQ7qvzD6I+2LFfjMQ7kVy3qiaieFfjus+ZUS whyVq9OAPnl5hu+cyxCdatgbKb682SlPh0Mmorsx3uR6UDOcQXR6zLiFSNcCf6cmk/C0 gWHebKdIaFtHHCKUSvvE034IbvGrWfxXnfvd4C7ED58Of6auHhxaDpUEpVQt3hSObOvZ 5FWg== X-Gm-Message-State: AOJu0YzsrenSbkU3pB6+ozGFN/IlqmvP8mvMnkqmMS9HKSadf4qClSsE 7QCb6VC4Hn2lJWt5F9BesgVjtg== X-Google-Smtp-Source: AGHT+IHfYRd2GZMGltUOIDuVqHLml+WqQhUAkxEy8QUA1nMKr5wWj9DOhrwgjT4jD06tdPeXmUeVIA== X-Received: by 2002:a17:906:53d9:b0:9a1:aa7b:482e with SMTP id p25-20020a17090653d900b009a1aa7b482emr5956781ejo.26.1692859663054; Wed, 23 Aug 2023 23:47:43 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id i12-20020a1709061ccc00b00991e2b5a27dsm10595780ejh.37.2023.08.23.23.47.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Aug 2023 23:47:42 -0700 (PDT) Message-ID: Date: Thu, 24 Aug 2023 08:47:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v6 4/5] net: ti: icssg-prueth: add packet timestamping and ptp support Content-Language: en-US To: MD Danish Anwar , Randy Dunlap , Roger Quadros , Simon Horman , Vignesh Raghavendra , Andrew Lunn , Richard Cochran , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" Cc: nm@ti.com, srk@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230823113254.292603-1-danishanwar@ti.com> <20230823113254.292603-5-danishanwar@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20230823113254.292603-5-danishanwar@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/08/2023 13:32, MD Danish Anwar wrote: > From: Roger Quadros > > Add packet timestamping TS and PTP PHC clock support. > > For AM65x and AM64x: > - IEP1 is not used > - IEP0 is configured in shadow mode with 1ms cycle and shared between > Linux and FW. It provides time and TS in number cycles, so special > conversation in ns is required. > - IEP0 shared between PRUeth ports. > - IEP0 supports PPS, periodic output. > - IEP0 settime() and enabling PPS required FW interraction. > - RX TS provided with each packet in CPPI5 descriptor. > - TX TS returned through separate ICSSG hw queues for each port. TX TS > readiness is signaled by INTC IRQ. Only one packet at time can be requested > for TX TS. > > Signed-off-by: Roger Quadros > Co-developed-by: Grygorii Strashko > Signed-off-by: Grygorii Strashko > Signed-off-by: Vignesh Raghavendra > Reviewed-by: Roger Quadros How patch author could review or not review its own code? How does it even work? I write a patch and for example judge - oh no, it is wrong, but I will still send it, just without my review. Or I write a patch - oh, I like it, I wrote excellent code, let me add review tag for my own code! > Reviewed-by: Simon Horman Where? Best regards, Krzysztof