From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xianwei Zhao <xianwei.zhao@amlogic.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v3 1/5] dt-bindings: pinctrl: Add support for Amlogic SoCs
Date: Mon, 20 Jan 2025 08:21:49 +0100 [thread overview]
Message-ID: <d08136ac-e08f-4e5d-b562-78529f34d86f@kernel.org> (raw)
In-Reply-To: <012cfaca-e8f5-4614-9393-a4a46a797adb@amlogic.com>
On 20/01/2025 06:57, Xianwei Zhao wrote:
> Hi Krzysztof,
> Thanks for reply.
>
> On 2025/1/17 16:48, Krzysztof Kozlowski wrote:
>> [ EXTERNAL EMAIL ]
>>
>> On Wed, Jan 15, 2025 at 02:41:59PM +0800, Xianwei Zhao wrote:
>>> +properties:
>>> + compatible:
>>> + const: amlogic,pinctrl-a4
>>> +
>>> + "#address-cells":
>>> + const: 2
>>> +
>>> + "#size-cells":
>>> + const: 2
>>
>> Why this moved to '2'? 32-bit was not enough?
>>
> Previously only represented a register address offset value, now
> directly represents a register, through 'ranges" which to represent.
> 32-bit is enough, but since APB bus is defined as 64-bit, here is
Changelog was silent on this.
> following. I increase support for 32-bit. Like the following values:
No, just keep one of these.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-20 7:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 6:41 [PATCH v3 0/5] Pinctrl: Add Amlogic pinctrl driver Xianwei Zhao via B4 Relay
2025-01-15 6:41 ` [PATCH v3 1/5] dt-bindings: pinctrl: Add support for Amlogic SoCs Xianwei Zhao via B4 Relay
2025-01-17 8:48 ` Krzysztof Kozlowski
2025-01-20 5:57 ` Xianwei Zhao
2025-01-20 7:21 ` Krzysztof Kozlowski [this message]
2025-01-15 6:42 ` [PATCH v3 2/5] pinctrl: pinconf-generic: Add API for pinmux propertity in DTS file Xianwei Zhao via B4 Relay
2025-01-15 6:42 ` [PATCH v3 3/5] pinctrl: Add driver support for Amlogic SoCs Xianwei Zhao via B4 Relay
2025-01-15 6:42 ` [PATCH v3 4/5] arm64: dts: amlogic: a4: add pinctrl node Xianwei Zhao via B4 Relay
2025-01-17 8:41 ` Krzysztof Kozlowski
2025-01-20 6:00 ` Xianwei Zhao
2025-01-15 6:42 ` [PATCH v3 5/5] MAINTAINERS: Add an entry for Amlogic pinctrl driver Xianwei Zhao via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d08136ac-e08f-4e5d-b562-78529f34d86f@kernel.org \
--to=krzk@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).