From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 504D9EB64DC for ; Tue, 18 Jul 2023 12:48:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231747AbjGRMsD (ORCPT ); Tue, 18 Jul 2023 08:48:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232126AbjGRMsB (ORCPT ); Tue, 18 Jul 2023 08:48:01 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7759188 for ; Tue, 18 Jul 2023 05:47:59 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2b70404a5a0so91693701fa.2 for ; Tue, 18 Jul 2023 05:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689684478; x=1692276478; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y+fpBsnE5go0f1t1rc3yenivCXFLqTDod2bLdDrF20I=; b=sxOl1Km89lkK1KQq/bEGKvyyw4dpGPYi4aiiVdbH/zkiPGj8SC4tRu8ZGg0CA3P5gk R0iB8Fsg4FJx49LQPwxVw5/antraWEl1QEO18pUq6Bu7eudaI/z+1UopXAxS4Ovt+eNF H/uSbgo05syy4+EuK6+7GbMvQcC5ZChb5kQwa8Zo15ahYbvRrKeoPCL+eoaQy92PjdPN lUlIHlM61PcYM6SqBXiSVoSPbt4n/j2lE0JMfGJuB4ffy35CHh1+LwQmwGi+oi+0qdx3 ZinXr2w9TzyBkK5swWcMGbX9XciYMuN9xFmXhHNMJ7u/XJfas3T+CF93C805hnLDzQls jSmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689684478; x=1692276478; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y+fpBsnE5go0f1t1rc3yenivCXFLqTDod2bLdDrF20I=; b=V/ETOFZZ2+4DB7aCAnJENNhVZ+ey8S2BaLiamvsVaK+22PhBBfkNKESD4Z3eNjHfUm MbnNdjwJlqIBGkdwOFCQErc3jWx52w9/M3OGLjnarVNo9UCfZ6NSyWTyjYROc8F9DvZ2 YVABM++gxqbnWBeyZ5SjmmOPAK4TZWITpDz7OjJiEnlp2+hroIToJrR8cHuNNH1MkjjG Z5FYZdRr7xFhGB3NbyO6ZLDezIjwbq/6ZIputUheO/8nlqWjHvfBaFvBjaOdT+SiSvvp p8MqJxsyb8CaqJ0MX6rCI1PoJ0u+TqYrSBMTVLVr5YXJZyNHWW7VVj7P+MIzy8jjcxyU XxQA== X-Gm-Message-State: ABy/qLbDYih0XKe+l//xLNFZUI1A6cF4qe/g8MUWX8vw23+4QTJ4Rv51 b0zZ5dkT094tWKp+lStMd4BJJQ== X-Google-Smtp-Source: APBJJlHaYF1oYWvL6+djJSqNXrsysizzv/7ID3YezX+m9Y7pnf78BNgH+IRF/nLhqba1MYG8P6eq3w== X-Received: by 2002:a2e:7a01:0:b0:2b7:a64:91bd with SMTP id v1-20020a2e7a01000000b002b70a6491bdmr14333345ljc.35.1689684478146; Tue, 18 Jul 2023 05:47:58 -0700 (PDT) Received: from [192.168.1.101] (abyj181.neoplus.adsl.tpnet.pl. [83.9.29.181]) by smtp.gmail.com with ESMTPSA id x11-20020a2e838b000000b002b6ec3d4a53sm479605ljg.50.2023.07.18.05.47.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 05:47:57 -0700 (PDT) Message-ID: Date: Tue, 18 Jul 2023 14:47:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 15/15] arm64: dts: qcom: sm6115: Add VDD_CX to GPU_CCC Content-Language: en-US To: Stephan Gerhold Cc: Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230717-topic-branch_aon_cleanup-v1-0-27784d27a4f4@linaro.org> <20230717-topic-branch_aon_cleanup-v1-15-27784d27a4f4@linaro.org> <8c5dc146-c305-bef9-0d97-76a91345ed1a@linaro.org> <9b28a17a-fe9c-3ff0-fa1d-320e75e174d0@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18.07.2023 13:56, Stephan Gerhold wrote: > On Mon, Jul 17, 2023 at 09:18:21PM +0200, Konrad Dybcio wrote: >> On 17.07.2023 19:23, Stephan Gerhold wrote: >>> On Mon, Jul 17, 2023 at 07:11:33PM +0200, Konrad Dybcio wrote: >>>> On 17.07.2023 18:56, Stephan Gerhold wrote: >>>>> On Mon, Jul 17, 2023 at 06:50:18PM +0200, Konrad Dybcio wrote: >>>>>> On 17.07.2023 18:28, Stephan Gerhold wrote: >>>>>>> On Mon, Jul 17, 2023 at 05:19:22PM +0200, Konrad Dybcio wrote: >>>>>>>> The GPU_CC block is powered by VDD_CX. Describe that. >>>>>>>> >>>>>>>> Signed-off-by: Konrad Dybcio >>>>>>>> --- >>>>>>>> arch/arm64/boot/dts/qcom/sm6115.dtsi | 2 ++ >>>>>>>> 1 file changed, 2 insertions(+) >>>>>>>> >>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi >>>>>>>> index 29b5b388cd94..bfaaa1801a4d 100644 >>>>>>>> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi >>>>>>>> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi >>>>>>>> @@ -1430,6 +1430,8 @@ gpucc: clock-controller@5990000 { >>>>>>>> clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, >>>>>>>> <&gcc GCC_GPU_GPLL0_CLK_SRC>, >>>>>>>> <&gcc GCC_GPU_GPLL0_DIV_CLK_SRC>; >>>>>>>> + power-domains = <&rpmpd SM6115_VDDCX>; >>>>>>>> + required-opps = <&rpmpd_opp_low_svs>; >>>>>>> >>>>>>> Where is this required-opp coming from? The clocks in gpucc seem to have >>>>>>> different voltage requirements depending on the rates, but we usually >>>>>>> handle that in the OPP tables of the consumer. >>>>>> The only lower levels defined for this SoC are VDD_MIN and VDD_RET, >>>>>> but quite obviously the GPU won't work then >>>>>> >>>>> >>>>> The levels needed for the GPU clocks to run should be in the GPU OPP >>>>> table though, just like e.g. sdhc2_opp_table for the SDCC clocks. >>>>> >>>>> I still don't really understand why this is specified here. :) >>>> The GPU_CC block needs this rail to be at a certain power level for >>>> register access. This describes that requirement. >>>> >>> >>> Can you show where this is defined downstream? On a quick look I didn't >>> see something like that anywhere. Or is this from some secret >>> documentation? >> As far as downstream goes, you can notice that no branch's or RCG's >> vdd tables ever define a level lower than the one I mentioned. >> > > As far as I can tell the vdd tables are only used when the clock is > actually enabled though, not for writing to registers while they are > disabled. Maybe, but you can also notice that even XO rates require at least SVS_LOW to function. Konrad