Re: [PATCH v2] arm64: dts: ti: k3-j784s4-evm: Add support for MCAN interfaces

["Kumar, Udit" <u-kumar1@ti.com>]

Thank you for patch

On 8/17/2023 2:19 PM, Bhavya Kapoor wrote:
> There are 2 MCAN instances in the mcu domain and 4 MCAN instances in the
> main domain. Add support for both MCAN nodes present in the mcu domain
> and MCAN16 that is present in the main domain and isn't muxed.

Could you add  description in commit message, why only 3 MCAN are 
enabled in this patch

despite of 6 available.

>
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
>
> Changelog v1->v2:
>   - Fixed issue with referencing mcu_mcan0 node that was causeing errors
>
> Link to v1 : https://lore.kernel.org/all/20230816193533.25722-1-b-kapoor@ti.com/
>
>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 87 ++++++++++++++++++++++++
>   1 file changed, 87 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> index 430b8a2c5df5..9fce3ce89507 100644
> [...]
> +	mcu_mcan1_pins_default: mcu-mcan1-default-pins {
> +		pinctrl-single,pins = <
> +			J784S4_WKUP_IOPAD(0x068, PIN_OUTPUT, 0) /* (H35) WKUP_GPIO0_4.MCU_MCAN1_TX */
> +			J784S4_WKUP_IOPAD(0x06c, PIN_INPUT, 0) /* (K36) WKUP_GPIO0_5.MCU_MCAN1_RX */
> +		>;

You can consider to drop pre-fix in GPIO details through out the patch

eg WKUP_GPIO0_5.MCU_MCAN1_RX to MCU_MCAN1_RX


> +	};
> +
> +	mcu_mcan0_gpio_pins_default: mcu-mcan0-gpio-default-pins {
> +		pinctrl-single,pins = <
> +			J784S4_WKUP_IOPAD(0x040, PIN_INPUT, 7) /* (J38) MCU_SPI0_D1.WKUP_GPIO0_69 */
> +		>;
> +	};
> +
> +	mcu_mcan1_gpio_pins_default: mcu-mcan1-gpio-default-pins {
> +		pinctrl-single,pins = <
> +			J784S4_WKUP_IOPAD(0x060, PIN_INPUT, 7) /* (J35) WKUP_GPIO0_2 */
> +		>;
> +	};
>   };
>   
>   &wkup_pmx0 {
> @@ -827,3 +885,32 @@ adc {
>   		ti,adc-channels = <0 1 2 3 4 5 6 7>;
>   	};
>   };
> +
> +&wkup_gpio_intr {
> +	status = "okay";
> +};
> +
> +&wkup_gpio0 {
> +	status = "okay";
> +};
> +
> +&mcu_mcan0 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mcu_mcan0_pins_default>;
> +	phys = <&transceiver1>;
> +};
> +
> +&mcu_mcan1 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mcu_mcan1_pins_default>;
> +	phys = <&transceiver2>;
> +};
> +
> +&main_mcan16 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_mcan16_pins_default>;
> +	phys = <&transceiver3>;
> +};