Re: [PATCH v3 08/15] thermal/drivers/tsens: Drop single-cell code for msm8939

[Konrad Dybcio <konrad.dybcio@linaro.org>]

On 20.12.2022 11:08, Bryan O'Donoghue wrote:
> On 20/12/2022 02:47, Dmitry Baryshkov wrote:
>> There is no dtsi file for msm8939 in the kernel sources. Drop the
>> compatibility with unofficial dtsi and remove support for handling the
>> single-cell calibration data on msm8939.
>>
>> Cc: Shawn Guo <shawn.guo@linaro.org>
>> Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> Maybe its a better idea to just - finally - get the 8939 dtsi upstream.
> 
> Is there anything that needs to change in this ? If not I'll just V2 in in the next few hours.
The point of this patchset is to remove logic like this, as it's
very repetetive and all it does is read fuses with a ton of magic
offsets. Dmitry pushes that to DT with the generic nvmem API, so
that instead of these magic &s and <<s, one is simply supposed to
define QFPROM fuses at the correct offset and with a matching bits=<>
property. This does not remove any functionality, it just changes
how the fuses are accessed and makes the code more generic.

Konrad
> 
> tsens: thermal-sensor@4a9000 {
>         compatible = "qcom,msm8939-tsens", "qcom,tsens-v0_1";
>          reg = <0x004a9000 0x1000>, /* TM */
>                <0x004a8000 0x1000>; /* SROT */
>          nvmem-cells = <&tsens_caldata>;
>          nvmem-cell-names = "calib";
>          #qcom,sensors = <10>;
>          interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
>          interrupt-names = "uplow";
>          #thermal-sensor-cells = <1>;
> };
> 
> https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=linux-next-22-12-15-msm8939-no-cpr&id=146087a134306dfb6e1ec48b20b19a278f336b15
> 
> ---
> bod