From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A3BC4332F for ; Tue, 20 Dec 2022 10:22:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229819AbiLTKWJ (ORCPT ); Tue, 20 Dec 2022 05:22:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233738AbiLTKWE (ORCPT ); Tue, 20 Dec 2022 05:22:04 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 259909594 for ; Tue, 20 Dec 2022 02:22:03 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id x11so11949301ljh.7 for ; Tue, 20 Dec 2022 02:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jxxu8mAn5D37rXv54OBicgE5WEKYbeNJX0Ra9K7kui0=; b=ZAOoVsOoxx0faw2zFkJBnZTmoSM1hESuATBy7sCXx4AgJvuxNTEbAYXk7wTBYhRe9Y cbXa52oSid0P8I14yCOd4ByFypCLcJV+r6nrMfbUEOvP1fom4XNFhQ1LjJTBJaw0F10D JQOIbPXiS+qAhlFx/4GEZchS2veQgpKU97++usk7nqmt/R9jkQTB9ZgT4DCnrblNxOJC qv8ENM03yQRHvPzcV1MK6g3hxFSBf8gXndy+D18vnt7p9boqtoXNBqS2P7VKlaw2eKVn kE57dtGR0ClgFzUUrAF08QHvSYKz0AKE3xdoLGlLGvORcWAXFy7OTF7nQbnVA74fkRo1 /LsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jxxu8mAn5D37rXv54OBicgE5WEKYbeNJX0Ra9K7kui0=; b=hN5Jr7MULld7XVVAK2IBAW0ItwzyzDLj/r3tIZHpXDpsi2vAPfa9JjX5n0Npkykb8A rFL8HcLNSSpMnT4I/EAnG8rxdWybbf/9cVOEGHI+d8lmdGiOPrRKn/95u9IE3Us+5cF/ kJY0z7hgAupUG7mMnT7dCct2MPbA0ZFfzxBnIdvBYtdIAIZeOFOd5D65tVHk+OkuJDQh tRkALENUoToqJFx7TrL8YKNO5yurkNT/JBsn2dw1nr05/xZYdrX403uTYnEf72SVhPYi WrxO4XWVmozRtaEJ3O6OkrHfZx+VeU2n125eA+yW0cNaSOBYxWy2p6BusqWaqrmUnEZg pM9A== X-Gm-Message-State: AFqh2krdbz+Xuza/YGkKsedNuaANVzWa4apGOSs+MDr5Uj+hipw6CSrs RwspCw5EFxZLI9GlphJ0iIB6Qg== X-Google-Smtp-Source: AMrXdXtfARpOOyYcE5O4K1e6ZvXUz7YxwwHF9LHz5ExiyxVTExjIFfFWs68zhgGEGrN5dY+Qp7QSFg== X-Received: by 2002:a05:651c:44f:b0:27e:34cf:17b1 with SMTP id g15-20020a05651c044f00b0027e34cf17b1mr6036232ljg.29.1671531721517; Tue, 20 Dec 2022 02:22:01 -0800 (PST) Received: from [192.168.1.101] (abxh212.neoplus.adsl.tpnet.pl. [83.9.1.212]) by smtp.gmail.com with ESMTPSA id i25-20020a2ea379000000b0026e0434eb1esm944227ljn.67.2022.12.20.02.22.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 02:22:01 -0800 (PST) Message-ID: Date: Tue, 20 Dec 2022 11:21:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 08/15] thermal/drivers/tsens: Drop single-cell code for msm8939 Content-Language: en-US To: Bryan O'Donoghue , Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Shawn Guo References: <20221220024721.947147-1-dmitry.baryshkov@linaro.org> <20221220024721.947147-9-dmitry.baryshkov@linaro.org> <78fd7174-9aa4-f067-72ca-514c8fb09ee5@linaro.org> From: Konrad Dybcio In-Reply-To: <78fd7174-9aa4-f067-72ca-514c8fb09ee5@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20.12.2022 11:08, Bryan O'Donoghue wrote: > On 20/12/2022 02:47, Dmitry Baryshkov wrote: >> There is no dtsi file for msm8939 in the kernel sources. Drop the >> compatibility with unofficial dtsi and remove support for handling the >> single-cell calibration data on msm8939. >> >> Cc: Shawn Guo >> Cc: Bryan O'Donoghue >> Signed-off-by: Dmitry Baryshkov > > Maybe its a better idea to just - finally - get the 8939 dtsi upstream. > > Is there anything that needs to change in this ? If not I'll just V2 in in the next few hours. The point of this patchset is to remove logic like this, as it's very repetetive and all it does is read fuses with a ton of magic offsets. Dmitry pushes that to DT with the generic nvmem API, so that instead of these magic &s and < property. This does not remove any functionality, it just changes how the fuses are accessed and makes the code more generic. Konrad > > tsens: thermal-sensor@4a9000 { >         compatible = "qcom,msm8939-tsens", "qcom,tsens-v0_1"; >          reg = <0x004a9000 0x1000>, /* TM */ >                <0x004a8000 0x1000>; /* SROT */ >          nvmem-cells = <&tsens_caldata>; >          nvmem-cell-names = "calib"; >          #qcom,sensors = <10>; >          interrupts = ; >          interrupt-names = "uplow"; >          #thermal-sensor-cells = <1>; > }; > > https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=linux-next-22-12-15-msm8939-no-cpr&id=146087a134306dfb6e1ec48b20b19a278f336b15 > > --- > bod