devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Stefan Wahren <wahrenst@gmx.net>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH v3 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format
Date: Wed, 11 Jun 2025 08:32:10 +0200	[thread overview]
Message-ID: <d0b13867-9aa4-4fb1-8492-0cc58e92c61d@kernel.org> (raw)
In-Reply-To: <aEhPTXHHulIP5MqG@lizhi-Precision-Tower-5810>

On 10/06/2025 17:29, Frank Li wrote:
>>
>>> +      $ref: /schemas/types.yaml#/definitions/flag
>>> +      description:
>>> +        Set the SPI data transfer of the QCA7000 to legacy mode.
>>> +        In this mode the SPI master must toggle the chip select
>>> +        between each data word. In burst mode these gaps aren't
>>> +        necessary, which is faster. This setting depends on how
>>> +        the QCA7000 is setup via GPIO pin strapping. If the
>>> +        property is missing the driver defaults to burst mode.
>>> +
>>> +  allOf:
>>> +    - $ref: /schemas/spi/spi-peripheral-props.yaml#
>>
>> This should be part of top-level allOf.
>>
>>> +
>>> +else:
>>> +  properties:
>>> +    current-speed:
>>> +      default: 115200
>>> +
>>> +  allOf:
>>> +    - $ref: /schemas/serial/serial-peripheral-props.yaml#
>>
>> Same here.
> 
> If it is one top, how to disable all properties in serial-peripheral-props.yaml
> if it connect to spi (reg exist).
You do not have to disallow them. If this is somehow useful, it can stay
here, although the earlier properties still need to be defined in top level.

Best regards,
Krzysztof

      reply	other threads:[~2025-06-11  6:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-06 15:51 [PATCH v3 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format Frank Li
2025-06-10  7:24 ` Krzysztof Kozlowski
2025-06-10 15:29   ` Frank Li
2025-06-11  6:32     ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0b13867-9aa4-4fb1-8492-0cc58e92c61d@kernel.org \
    --to=krzk@kernel.org \
    --cc=Frank.li@nxp.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).