From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9206EEB64D7 for ; Mon, 26 Jun 2023 08:31:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229502AbjFZIbD (ORCPT ); Mon, 26 Jun 2023 04:31:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230079AbjFZIa7 (ORCPT ); Mon, 26 Jun 2023 04:30:59 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 871DFE7D for ; Mon, 26 Jun 2023 01:30:56 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-98e39784a85so212996266b.1 for ; Mon, 26 Jun 2023 01:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687768255; x=1690360255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z6Q9XtGAe9pmT920uAOyU/UADbYVSu2ITB2+DxW4Lk8=; b=SWpuU3MrBWg1VaE3Fr8Z0YRmYMhGlk9J9qdttbWilg6IB5RjkTOJY2u06kCQ+bfGe8 DJSrlakWQeo/fHUSy9zX1JzfROWovG39LUHZiipNakCc6n5StFwZ89CVCy7dco4J0A8h 3k3XoTfj1+97Mo9fZIufMJ7RUsLcT6SfWWGZVPNT6SuyAKuA2jZjScOcmZ6cXlJnguW3 oa7RFipoKK5qHVyYnpSgYjJe6wVuNVwHvDkBK3oGvlrH5462wxf9FDmphYzZhKTcSRvk f7PoQpx3vPxp0DyWOVRaMGtM7SLmVuYOv7lDa7Ceb7/gkoXGCgxc97Q1/HoZMUztv9dI mZhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687768255; x=1690360255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z6Q9XtGAe9pmT920uAOyU/UADbYVSu2ITB2+DxW4Lk8=; b=cnnhz6r8VnjJYSp8q0ghl0KqUixZp5mJv4e+hGwVBqt79aX7rdmW+CklPomGR18TX+ Rbh03M9jfhZI1AqIxkWymX2yVmm0mabAfgIj6TYdS9i5lhv5zoCPb3w28dMaKsVTH7SU qR7fAQ5VXyp2Fj4pNmamIjjFhIo9d1XI+8pGtYhxsJBpmSvqqrmHMaaGOLh+qQBvHll9 AMpCVYPg9FPzrBE+/FI16TS/A/iZc3r7YcZd+iw6hVCkTR3lvlvx/qpjvjEIeo0h24mT abB80KxJzJXANDuOo0xfksVulxNU3G+Ko5Lg9C5kZwP2Zq+wDZZAlooq5rZwk5FIxpoP DiEg== X-Gm-Message-State: AC+VfDyzSXCsYsGtyxpctMUEczgxU2NGC5DWoXOHGh6AI57DAOGpeBcC t2oxOqoTJ9HPuoj2TzV1jTtAhw== X-Google-Smtp-Source: ACHHUZ7nn/1Fi/+3MWyVpG6zaAZrJEd0canSK2GOthmprJI4z4sBP6lCZi7wDvbASjZjDl/i30AO9Q== X-Received: by 2002:a17:907:7ba5:b0:982:4b35:c0b6 with SMTP id ne37-20020a1709077ba500b009824b35c0b6mr27532143ejc.1.1687768254853; Mon, 26 Jun 2023 01:30:54 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id r1-20020a1709064d0100b0098e0d1c1096sm2397810eju.136.2023.06.26.01.30.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jun 2023 01:30:54 -0700 (PDT) Message-ID: Date: Mon, 26 Jun 2023 10:30:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 1/6] dt-bindings: nvmem: sec-qfprom: Add bindings for secure qfprom Content-Language: en-US To: Komal Bajaj , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230623141806.13388-1-quic_kbajaj@quicinc.com> <20230623141806.13388-2-quic_kbajaj@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/06/2023 10:22, Komal Bajaj wrote: >> >>> + >>> +allOf: >>> + - $ref: nvmem.yaml# >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - qcom,qdu1000-sec-qfprom >>> + - const: qcom,sec-qfprom >>> + >>> + reg: >>> + items: >>> + - description: The secure qfprom corrected region. >>> + >>> + # Needed if any child nodes are present. >>> + "#address-cells": >>> + const: 1 >>> + "#size-cells": >>> + const: 1 >> Drop both, they are not needed. > > I didn't get it. Can you please explain why these are not needed as this > node will have child nodes which will use single value for address and size. I suspect they are already defined. Do other bindings (for cases with children) have them? If not, why here it would be different? Best regards, Krzysztof