From: "Roger Lu (陸瑞傑)" <Roger.Lu@mediatek.com>
To: "eballetbo@gmail.com" <eballetbo@gmail.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"khilman@kernel.org" <khilman@kernel.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"drinkcat@google.com" <drinkcat@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Jia-wei Chang (張佳偉)" <Jia-wei.Chang@mediatek.com>,
"Fan Chen (陳凡)" <fan.chen@mediatek.com>
Subject: Re: [PATCH v1 10/13] soc: mediatek: mtk-svs: restore default voltages when svs init02 fail
Date: Tue, 10 Jan 2023 05:30:18 +0000 [thread overview]
Message-ID: <d0c0bdfd025c72f8e69eab2e699fc8d8a6d97199.camel@mediatek.com> (raw)
In-Reply-To: <ce7698f3-8b40-1394-342e-e6b099f9f77e@collabora.com>
Hi AngeloGioacchino,
Sorry for the late reply and thanks for the advices always.
On Tue, 2023-01-03 at 13:49 +0100, AngeloGioacchino Del Regno wrote:
> Il 26/12/22 10:42, Roger Lu ha scritto:
> > If svs init02 fail, it means we cannot rely on svs bank voltages anymore.
> > We need to disable svs function and restore DVFS opp voltages back to the
> > default voltages for making sure we have enough DVFS voltages.
> >
> > Signed-off-by: Roger Lu <roger.lu@mediatek.com>
>
> This needs a Fixes tag... and it also needs to apply to older kernels, as
> MT8183 does use SVS in previous versions.
No problem. I'll add a Fixes tag.
>
> Perhaps you can send a different patch, without the cleanups, only for the
> backport?
> Otherwise you'll have to duplicate
> svs_bank_disable_and_restore_default_volts()
> again before cleaning up...
>
> I'll leave the choice to you.
I'll reorder the patch to put cleanup patches first and fix patches next in the
patchset. Thanks for the advice again.
>
> Regards,
> Angelo
next prev parent reply other threads:[~2023-01-10 5:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 9:42 [PATCH v1 0/13] Enahance SVS's robustness Roger Lu
2022-12-26 9:42 ` [PATCH v1 01/13] soc: mediatek: mtk-svs: enable the IRQ later Roger Lu
2022-12-26 9:42 ` [PATCH v1 02/13] soc: mediatek: mtk-svs: clean up platform probing Roger Lu
2022-12-26 9:42 ` [PATCH v1 03/13] soc: mediatek: mtk-svs: improve readability of platform_probe Roger Lu
2022-12-26 9:42 ` [PATCH v1 04/13] soc: mediatek: mtk-svs: move svs_platform_probe into probe Roger Lu
2022-12-26 9:42 ` [PATCH v1 05/13] soc: mediatek: mtk-svs: delete superfluous platform data entries Roger Lu
2022-12-26 9:42 ` [PATCH v1 06/13] soc: mediatek: mtk-svs: use svs get efuse common function Roger Lu
2022-12-26 9:42 ` [PATCH v1 07/13] soc: mtk-svs: mt8183: refactor o_slope calculation Roger Lu
2023-01-03 12:49 ` AngeloGioacchino Del Regno
2022-12-26 9:42 ` [PATCH v1 08/13] soc: mediatek: mtk-svs: add main_clk check during system-wide suspend Roger Lu
2022-12-26 9:42 ` [PATCH v1 09/13] soc: mediatek: mtk-svs: use common function to disable restore voltages Roger Lu
2023-01-03 12:49 ` AngeloGioacchino Del Regno
2022-12-26 9:42 ` [PATCH v1 10/13] soc: mediatek: mtk-svs: restore default voltages when svs init02 fail Roger Lu
2023-01-03 12:49 ` AngeloGioacchino Del Regno
2023-01-10 5:30 ` Roger Lu (陸瑞傑) [this message]
2022-12-26 9:42 ` [PATCH v1 11/13] soc: mediatek: mtk-svs: add thermal voltage compensation if needed Roger Lu
2023-01-03 12:49 ` AngeloGioacchino Del Regno
2022-12-26 9:42 ` [PATCH v1 12/13] soc: mediatek: mtk-svs: Use pm_runtime_resume_and_get() in svs_init01() Roger Lu
2023-01-03 12:49 ` AngeloGioacchino Del Regno
2022-12-26 9:42 ` [PATCH v1 13/13] soc: mediatek: mtk-svs: keep svs alive even though debug cmd create fail Roger Lu
2023-01-03 12:49 ` AngeloGioacchino Del Regno
2023-01-10 5:35 ` Roger Lu (陸瑞傑)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0c0bdfd025c72f8e69eab2e699fc8d8a6d97199.camel@mediatek.com \
--to=roger.lu@mediatek.com \
--cc=Jia-wei.Chang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@google.com \
--cc=eballetbo@gmail.com \
--cc=fan.chen@mediatek.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).