devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Joakim Zhang <qiangqing.zhang@nxp.com>,
	"robh@kernel.org" <robh@kernel.org>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 0/2] can: flexcan: add PE clock source select support
Date: Wed, 27 Feb 2019 12:00:37 +0100	[thread overview]
Message-ID: <d0d2d140-0453-77a5-db6a-88c27f47bbc4@pengutronix.de> (raw)
In-Reply-To: <47070f2a-4500-4b48-3718-66569a7cc89e@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 1382 bytes --]

On 2/27/19 9:46 AM, Marc Kleine-Budde wrote:
> On 12/13/18 8:07 AM, Joakim Zhang wrote:
>> The patch set intends to add support for PE clock source select. The
>> FlexCAN controller can parse "fsl,clk-source" property from device tree
>> to select clock source.
>>
>> Dong Aisheng (2):
>>   Documentation: can: flexcan: add PE clock source property to device
>>     tree
>>   can: flexcan: add support for PE clock source select
>>
>>  .../bindings/net/can/fsl-flexcan.txt           |  8 ++++++++
>>  drivers/net/can/flexcan.c                      | 18 ++++++++++++++----
>>  2 files changed, 22 insertions(+), 4 deletions(-)
> 
> Added to linux-can-next.

With one change:

> @@ -1369,7 +1371,10 @@ static int register_flexcandev(struct net_device *dev)
>                 goto out_clks_disable;
> 
>         reg = priv->read(&regs->ctrl);
> -       reg |= FLEXCAN_CTRL_CLK_SRC;
> +       if (priv->clk_src)
> +               reg |= FLEXCAN_CTRL_CLK_SRC;
> +       else
> +               reg &= ~FLEXCAN_CTRL_CLK_SRC;

...the FLEXCAN_CTRL_CLK_SRC bit is cleared now.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2019-02-27 11:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13  7:07 [PATCH 0/2] can: flexcan: add PE clock source select support Joakim Zhang
2018-12-13  7:07 ` [PATCH 1/2] Documentation: can: flexcan: add PE clock source property to device tree Joakim Zhang
2018-12-20 20:22   ` Rob Herring
2018-12-21  3:34     ` Aisheng Dong
2018-12-21  4:28     ` Joakim Zhang
2018-12-13  7:08 ` [PATCH 2/2] can: flexcan: add support for PE clock source select Joakim Zhang
2019-01-17  6:27 ` [PATCH 0/2] can: flexcan: add PE clock source select support Joakim Zhang
2019-02-14  9:57   ` Joakim Zhang
2019-02-27  8:46 ` Marc Kleine-Budde
2019-02-27 11:00   ` Marc Kleine-Budde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0d2d140-0453-77a5-db6a-88c27f47bbc4@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qiangqing.zhang@nxp.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).