From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
linus.walleij@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
catalin.marinas@arm.com, will@kernel.org
Cc: arnd@arndb.de, geert+renesas@glider.be, nfraprado@collabora.com,
rafal@milecki.pl, peng.fan@nxp.com,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, quic_tsoni@quicinc.com,
quic_shashim@quicinc.com, quic_kaushalk@quicinc.com,
quic_tdas@quicinc.com, quic_tingweiz@quicinc.com,
quic_aiquny@quicinc.com, kernel@quicinc.com
Subject: Re: [PATCH 2/3] pinctrl: qcom: Add SM4450 pinctrl driver
Date: Fri, 8 Sep 2023 10:45:14 +0200 [thread overview]
Message-ID: <d0d6825a-97f7-405b-910e-772100c325a9@linaro.org> (raw)
In-Reply-To: <20230908063843.26835-3-quic_tengfan@quicinc.com>
On 8.09.2023 08:38, Tengfei Fan wrote:
> Add pinctrl driver for TLMM block found in SM4450 SoC.
>
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
[...]
> +/* Every pin is maintained as a single group, and missing or non-existing pin
/*
* Every pin
> + * would be maintained as dummy group to synchronize pin group index with
> + * pin descriptor registered with pinctrl core.
> + * Clients would not be able to request these dummy pin groups.
> + */
[...]
> +static const int sm4450_acpi_reserved_gpios[] = {
> + 0, 1, 2, 3, 136, -1
> +};
Are you ever going to boot with ACPI on this platform?
Why reserve UFS_RESET?
Why are 0-3 reserved? FP reader? Please leave a comment. Or
delete this.
Konrad
next prev parent reply other threads:[~2023-09-08 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 6:38 [PATCH 0/3] pinctl: qcom: Add SM4450 pinctrl driver Tengfei Fan
2023-09-08 6:38 ` [PATCH 1/3] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl Tengfei Fan
2023-09-08 7:22 ` Rob Herring
2023-09-08 7:28 ` Tengfei Fan
2023-09-08 7:53 ` Krzysztof Kozlowski
2023-09-08 7:56 ` Tengfei Fan
2023-09-08 6:38 ` [PATCH 2/3] pinctrl: qcom: Add SM4450 pinctrl driver Tengfei Fan
2023-09-08 8:45 ` Konrad Dybcio [this message]
2023-09-11 1:23 ` Tengfei Fan
2023-09-08 6:38 ` [PATCH 3/3] arm64: defconfig: Enable pinctrl for SM4450 Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0d6825a-97f7-405b-910e-772100c325a9@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kernel@quicinc.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=peng.fan@nxp.com \
--cc=quic_aiquny@quicinc.com \
--cc=quic_kaushalk@quicinc.com \
--cc=quic_shashim@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_tengfan@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).