From: David Lechner <dlechner@baylibre.com>
To: Sirat <email@sirat.me>, Conor Dooley <conor@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iio: proximity: add ST VL53L1X ToF sensor
Date: Sat, 7 Mar 2026 10:55:56 -0600 [thread overview]
Message-ID: <d0ec6a2f-6d30-4774-8950-15dd3c4b020b@baylibre.com> (raw)
In-Reply-To: <CANn+LW+kWoTnw32Db_T4t4JCCcCRtUead53i5tmc7Xeme=9X-w@mail.gmail.com>
On 3/3/26 1:49 PM, Sirat wrote:
> Hi Conor,
>
> On Wed, Mar 4, 2026 at 1:12 AM Conor Dooley <conor@kernel.org> wrote:
>>
>> On Tue, Mar 03, 2026 at 03:02:40PM +0600, Siratul Islam wrote:
>>> Add device tree binding documentation for the STMicroelectronics
>>> VL53L1X Time-of-Flight ranging sensor connected via I2C.
>>>
>>> Signed-off-by: Siratul Islam <email@sirat.me>
>>> ---
>
>>> + vdd-supply: true
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>
>> Are you sure the supply is not mandatory?
>>
>
> It is mandatory. The driver uses non optional devm_regulator_get().
> Will make the binding
> match in v2.
>
> Thanks,
> Sirat
From the point of view of the devicetree, it doesn't matter what
the driver does. It matters that the chip can't work without
power. ;-)
next prev parent reply other threads:[~2026-03-07 16:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 9:02 [PATCH 0/3] iio: proximity: add driver for ST VL53L1X ToF sensor Siratul Islam
2026-03-03 9:02 ` [PATCH 1/3] dt-bindings: iio: proximity: add " Siratul Islam
2026-03-03 19:12 ` Conor Dooley
2026-03-03 19:49 ` Sirat
2026-03-07 16:55 ` David Lechner [this message]
2026-03-03 9:02 ` [PATCH 2/3] iio: proximity: add driver for " Siratul Islam
2026-03-07 13:59 ` Jonathan Cameron
2026-03-08 10:37 ` Sirat
2026-03-08 18:06 ` Jonathan Cameron
2026-03-07 17:17 ` David Lechner
2026-03-08 11:04 ` Sirat
2026-03-08 17:33 ` David Lechner
2026-03-03 9:02 ` [PATCH 3/3] MAINTAINERS: add entry for ST VL53L1X ToF sensor driver Siratul Islam
2026-03-07 16:57 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0ec6a2f-6d30-4774-8950-15dd3c4b020b@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=email@sirat.me \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox