From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F56E3C1E for ; Wed, 18 Oct 2023 15:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HryORvhy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C630C433C9; Wed, 18 Oct 2023 15:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697641505; bh=1QoRzC9jJwTaFmGrM4LiozZejJzJBfoUoG9IBJ/e5TQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HryORvhyVhhLAZoAiFy39YrretnQ1CRqMzpISFzRh12yhMMjUTqHaJIbmmzxHiFNe W3FsgaW4p6gX5s1YES6KAaoc5SUvh7Q9AF9VclNyZkKTbWe9bnPl66zhBXskmPh+vZ EQqsSEfspbB+9mtMOJrQQBmPyhNugY+GDQHprxWdbweERs7goQGANR7DLeJkuW72lc uvPYGxRLUZgLWUenIhamhKTvYHB8iBB1MPfZOHiTbe5DwliXMNhkgwoz2ieH+CuLuq ezCPQXULeFAeGBWGtI4hGGBIQlR2hYNVTa401dWQhuoS3gFTyTVR07lsfJIwSZGJw0 QM1LFRV7lnQqQ== Message-ID: Date: Thu, 19 Oct 2023 00:05:01 +0900 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 05/26] PM / devfreq: rockchip-dfi: dfi store raw values in counter struct Content-Language: en-US To: Sascha Hauer , linux-rockchip@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Heiko Stuebner , Kyungmin Park , MyungJoo Ham , Will Deacon , Mark Rutland , kernel@pengutronix.de, Michael Riesch , Robin Murphy , Vincent Legoll , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, Sebastian Reichel , Jonathan Cameron References: <20231018061714.3553817-1-s.hauer@pengutronix.de> <20231018061714.3553817-6-s.hauer@pengutronix.de> From: Chanwoo Choi In-Reply-To: <20231018061714.3553817-6-s.hauer@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23. 10. 18. 15:16, Sascha Hauer wrote: > When adding perf support to the DFI driver the perf part will > need the raw counter values, so move the fixed * 4 factor to > rockchip_dfi_get_event(). > > Reviewed-by: Jonathan Cameron > Reviewed-by: Sebastian Reichel > Signed-off-by: Sascha Hauer > --- > drivers/devfreq/event/rockchip-dfi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > index 6b1ef29df7048..680f629da64fc 100644 > --- a/drivers/devfreq/event/rockchip-dfi.c > +++ b/drivers/devfreq/event/rockchip-dfi.c > @@ -97,7 +97,7 @@ static int rockchip_dfi_get_busier_ch(struct devfreq_event_dev *edev) > /* Find out which channel is busier */ > for (i = 0; i < RK3399_DMC_NUM_CH; i++) { > dfi->ch_usage[i].access = readl_relaxed(dfi_regs + > - DDRMON_CH0_DFI_ACCESS_NUM + i * 20) * 4; > + DDRMON_CH0_DFI_ACCESS_NUM + i * 20); > dfi->ch_usage[i].total = readl_relaxed(dfi_regs + > DDRMON_CH0_COUNT_NUM + i * 20); > tmp = dfi->ch_usage[i].access; > @@ -149,7 +149,7 @@ static int rockchip_dfi_get_event(struct devfreq_event_dev *edev, > > busier_ch = rockchip_dfi_get_busier_ch(edev); > > - edata->load_count = dfi->ch_usage[busier_ch].access; > + edata->load_count = dfi->ch_usage[busier_ch].access * 4; > edata->total_count = dfi->ch_usage[busier_ch].total; > > return 0; Already applied it on v7. -- Best Regards, Samsung Electronics Chanwoo Choi