From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45940C433F5 for ; Fri, 20 May 2022 10:33:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348152AbiETKd4 (ORCPT ); Fri, 20 May 2022 06:33:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348158AbiETKdy (ORCPT ); Fri, 20 May 2022 06:33:54 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A388890CF5 for ; Fri, 20 May 2022 03:33:51 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id bu29so13655195lfb.0 for ; Fri, 20 May 2022 03:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LVuXV2CFkZpxeowkVLO5pGMYN265kJ7DW3lBIgIDU24=; b=InUnde+pllALKVumjbiMlajeXmkUXICnixbwvCZrM07LAT6bLxW2RoJIoKVpAIqEBP SQ454Q8b4hJzKlVazi/dNpk4cl2AuL2k8V5V+nOHwbnU50c+GaysxSlep6oIuwFtqQWv DvmNc7Qcg85PjEvJlfbMNfT1/FFRsRdi+Lwk7R8Bgi0azdLVrnumkgnJQyIQB9DeDXje j1y6gASuRwcFkP4PtezD0X9dqQgplOIID9/Yy73lmjbEUTQB1EgCnIRXtEL3VRW80Jwk 5QFy0Vy9jgDdT8kK+4uCTMpiUAfw4i5iAVCVuSXtU1wXtkHIQQqfKl+oYGH0xfaiNsRv G2rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LVuXV2CFkZpxeowkVLO5pGMYN265kJ7DW3lBIgIDU24=; b=qgcf6Im4TzZNsV2W3DRhAcuLcFtBiPvyUrgkFU3SmcRGRVmRVaL/K5R6tH8GJ2Qy9p 4AILzNesc8n1mzg45IHmQJ/DdWEHgg+7/b8Fz0OQct1aQWJZNzjkqiByYiYJjCp1/lFb g/YGzfdtpiYxbdoXoCzFAeqzI+a5OuXN3lUzFj2yFds7YeRYOGDca4EWwCT6LaKBTUZ+ KJqhb8e/5aI5ygVfT5yFb3W0O5EXtksBYajTnhyV3zyH8iqmcBSsSqDYeMC7bZW8MsQW be1JPATi/wE5crCVcqDr5+Z5wbcebKWcQULKEo2YYVlemHaNaROwX4xEXRdraUeCijvr P0/Q== X-Gm-Message-State: AOAM531pOMiEgvZer7dTcUygLjBUkyiBmYev8zuGjLt4Gh8Xt13Dir9y nTYsEj5H5TbA/3eBRFgEwu28aQ== X-Google-Smtp-Source: ABdhPJxV/WhaALYTuCSJnI35g5RQjc0IJIDrx2kW3apuDK+PAwurIeIvcZtE3yzf68WdR3a92Q9bmQ== X-Received: by 2002:a05:6512:1108:b0:477:93a5:328e with SMTP id l8-20020a056512110800b0047793a5328emr6571383lfg.546.1653042830064; Fri, 20 May 2022 03:33:50 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u2-20020a2ea162000000b0024f3d1daef5sm262248ljl.125.2022.05.20.03.33.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 03:33:49 -0700 (PDT) Message-ID: Date: Fri, 20 May 2022 12:33:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 3/5] dt-bindings: interconnect: qcom: Reuse new rpmh-common bindings Content-Language: en-US To: Luca Weiss , linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Odelu Kukatla , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220520070318.48521-1-luca.weiss@fairphone.com> <20220520070318.48521-4-luca.weiss@fairphone.com> From: Krzysztof Kozlowski In-Reply-To: <20220520070318.48521-4-luca.weiss@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/05/2022 09:03, Luca Weiss wrote: > Stop defining the properties twice and use the ones provided in the new > qcom,rpmh-common.yaml. > > Signed-off-by: Luca Weiss > --- > Changes since v1: > * New patch > > .../bindings/interconnect/qcom,rpmh.yaml | 22 +++++-------------- > 1 file changed, 5 insertions(+), 17 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > index fae3363fed02..e822dc099339 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > @@ -18,6 +18,9 @@ description: | > least one RPMh device child node pertaining to their RSC and each provider > can map to multiple RPMh resources. > > +allOf: > + - $ref: qcom,rpmh-common.yaml# > + > properties: > reg: > maxItems: 1 > @@ -131,28 +134,13 @@ properties: > - qcom,sm8450-pcie-anoc > - qcom,sm8450-system-noc > > - '#interconnect-cells': > - enum: [ 1, 2 ] > - > - qcom,bcm-voters: > - $ref: /schemas/types.yaml#/definitions/phandle-array > - items: > - maxItems: 1 > - description: | > - List of phandles to qcom,bcm-voter nodes that are required by > - this interconnect to send RPMh commands. > - > - qcom,bcm-voter-names: > - description: | > - Names for each of the qcom,bcm-voters specified. > + '#interconnect-cells': true > So this explains why your previous patch had such values... The order is messed up - first you move common parts to common file, then you add SM6350 support. Best regards, Krzysztof