From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17BB2C4332F for ; Tue, 8 Nov 2022 12:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233983AbiKHMnj (ORCPT ); Tue, 8 Nov 2022 07:43:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233631AbiKHMni (ORCPT ); Tue, 8 Nov 2022 07:43:38 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DEA3A182 for ; Tue, 8 Nov 2022 04:43:37 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id d20so20891418ljc.12 for ; Tue, 08 Nov 2022 04:43:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L7CgUpuOhO0bb1QuM22uaBQfdN8D1V8Stm51wZ3T8Gg=; b=LIsNsGwiOurmNx0OiaNbMbgKLGxxPZrE5Ef9wutqCgn7FlkzxjxESBTv3v5MOPksqR +bn6BF7a8oe/Z+zDgdYcAe4OYq7KpJBO3vw2hQS1Jg6YpZK1J2wu4sAoGAyJw6QiArTT 87uHy2JAD/DMD0745o4HuGf024W0kcucak9yYExf7+v8aMEXIW5G1KZhI24FlN4lISC+ f3dNPUor52xNTcG4+8WGROATKhFASFjr6G6F9q7MheigHNQ6HnovXw4Q1+3KB1OZEWjz cZsaxh/f/tZPNUavangu+lnQoyisMrN/paYt1HmbeyX5gM7EGH5GR0WuzCqGSQ75spx9 0IBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L7CgUpuOhO0bb1QuM22uaBQfdN8D1V8Stm51wZ3T8Gg=; b=OpuU6s94bcusmW/CoEdD7fRSd/KVDbMpSU6sybkprM0KTUtPYXIiDA/hk4gbxuXeRd l8MRXdM5Fmz5fcEBJwhijaBZ71830TBsw4QSI8gwvKBlYkjf4Ol9J/sWRD4ebMSVM9vC eRgE2/GQohcFH/St7BphRuUQjqkUQRNBEbnUX/WYwXNN6CJgXQrdIWzeZZyuAiEce97g HZ9Xs/8vPSWtu8Z2I+gI5qi4J/+65G9Nil1XXMptyTDzT0+d8FgUWqFh0UTmZCCn8w9x Qk3Z3hS6R8IML55PGK8spG2/MxxnOofCtJbsaiDoUCg8BoCd/n+x8uOYHxRXErESEAvp 1aGQ== X-Gm-Message-State: ACrzQf1ugGBV9i5/JjBCM3LNgD5/vKccGJsPHcDQAF4CcYx/7FoiJwxM eLqfhcFdefSulMKb5giHlthprA== X-Google-Smtp-Source: AMsMyM4plXmGbRfyztNmF+l3FkFcv6jZ3fAguBNi/YGBes4B3ZKtrI2nDy+X8O0NPJiI8DvlCweMoQ== X-Received: by 2002:a2e:bcc5:0:b0:277:978:dae0 with SMTP id z5-20020a2ebcc5000000b002770978dae0mr7218782ljp.475.1667911415455; Tue, 08 Nov 2022 04:43:35 -0800 (PST) Received: from [10.27.10.248] ([195.165.23.90]) by smtp.gmail.com with ESMTPSA id m4-20020a056512114400b004b0a1e77cb6sm1765227lfg.139.2022.11.08.04.43.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 04:43:35 -0800 (PST) Message-ID: Date: Tue, 8 Nov 2022 15:43:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2 08/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Content-Language: en-GB To: Bryan O'Donoghue , robdclark@gmail.com, quic_abhinavk@quicinc.com, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, quic_mkrishn@quicinc.com, linux-arm-msm@vger.kernel.org Cc: Sean Paul , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221107235654.1769462-1-bryan.odonoghue@linaro.org> <20221107235654.1769462-9-bryan.odonoghue@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20221107235654.1769462-9-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/11/2022 02:56, Bryan O'Donoghue wrote: > Each compatible has a different set of clocks which are associated with it. > Add in the list of clocks for each compatible. > > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Bryan O'Donoghue > --- > .../display/msm/dsi-controller-main.yaml | 177 +++++++++++++++--- > 1 file changed, 150 insertions(+), 27 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index 9db3e63acda3d..c975df0ca22fc 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -9,24 +9,22 @@ title: Qualcomm Display DSI controller > maintainers: > - Krishna Manikandan > > -allOf: > - - $ref: "../dsi-controller.yaml#" > - > properties: > compatible: > - enum: > - - qcom,dsi-ctrl-6g-qcm2290 > - - qcom,mdss-dsi-ctrl > - - qcom,mdss-dsi-ctrl-apq8064 > - - qcom,mdss-dsi-ctrl-msm8916 > - - qcom,mdss-dsi-ctrl-msm8974 > - - qcom,mdss-dsi-ctrl-msm8996 > - - qcom,mdss-dsi-ctrl-sc7180 > - - qcom,mdss-dsi-ctrl-sc7280 > - - qcom,mdss-dsi-ctrl-sdm630 > - - qcom,mdss-dsi-ctrl-sdm660 > - - qcom,mdss-dsi-ctrl-sdm845 > - - qcom,mdss-dsi-ctrl-sm8250 > + items: > + - enum: > + - qcom,dsi-ctrl-6g-qcm2290 > + - qcom,mdss-dsi-ctrl-apq8064 > + - qcom,mdss-dsi-ctrl-msm8916 > + - qcom,mdss-dsi-ctrl-msm8974 > + - qcom,mdss-dsi-ctrl-msm8996 > + - qcom,mdss-dsi-ctrl-sc7180 > + - qcom,mdss-dsi-ctrl-sc7280 > + - qcom,mdss-dsi-ctrl-sdm630 > + - qcom,mdss-dsi-ctrl-sdm660 > + - qcom,mdss-dsi-ctrl-sdm845 > + - qcom,mdss-dsi-ctrl-sm8250 > + - const: qcom,mdss-dsi-ctrl I'd prefer to have this part squashed into the previous patch. > > reg: > maxItems: 1 > @@ -51,17 +49,8 @@ properties: > minItems: 6 > > clock-names: > - items: > - - const: byte > - - const: byte_intf > - - const: pixel > - - const: core > - - const: iface > - - const: bus > - - const: core_mmss > - - const: mdp_core > - - const: mnoc > minItems: 6 > + maxItems: 9 > > phys: > maxItems: 1 > @@ -169,6 +158,140 @@ required: > - vddio-supply > - vdda-supply > > +allOf: > + - $ref: "../dsi-controller.yaml#" > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,mdss-dsi-ctrl-apq8064 > + then: > + properties: > + clocks: > + maxItems: 7 > + clock-names: > + items: > + - const: iface > + - const: bus > + - const: core_mmss > + - const: src > + - const: byte > + - const: pixel > + - const: core Empty lines between clauses please. > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,mdss-dsi-ctrl-msm8916 > + then: > + properties: > + clocks: > + maxItems: 6 > + clock-names: > + items: > + - const: mdp_core > + - const: iface > + - const: bus > + - const: byte > + - const: pixel > + - const: core > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,mdss-dsi-ctrl-msm8974 > + then: > + properties: > + clocks: > + maxItems: 3 > + clock-names: > + items: > + - const: iface > + - const: bus > + - const: vsync > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,mdss-dsi-ctrl-msm8996 > + then: > + properties: > + clocks: > + maxItems: 7 > + clock-names: > + items: > + - const: mdp_core > + - const: byte > + - const: iface > + - const: bus > + - const: core_mmss > + - const: pixel > + - const: core > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,mdss-dsi-ctrl-sc7180 > + - qcom,mdss-dsi-ctrl-sc7280 > + - qcom,mdss-dsi-ctrl-sm8250 > + then: > + properties: > + clocks: > + maxItems: 6 > + clock-names: > + items: > + - const: byte > + - const: byte_intf > + - const: pixel > + - const: core > + - const: iface > + - const: bus > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,mdss-dsi-ctrl-sdm630 > + - qcom,mdss-dsi-ctrl-sdm660 > + then: > + properties: > + clocks: > + maxItems: 9 > + clock-names: > + items: > + - const: mdp_core > + - const: byte > + - const: byte_intf > + - const: mnoc > + - const: iface > + - const: bus > + - const: core_mmss > + - const: pixel > + - const: core > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,mdss-dsi-ctrl-sdm845 > + then: > + properties: > + clocks: > + maxItems: 6 > + clock-names: > + items: > + - const: byte > + - const: byte_intf > + - const: pixel > + - const: core > + - const: iface > + - const: bus > + > additionalProperties: false > > examples: > @@ -179,7 +302,7 @@ examples: > #include > > dsi@ae94000 { > - compatible = "qcom,mdss-dsi-ctrl"; > + compatible = "qcom,mdss-dsi-ctrl-sc7180", "qcom,mdss-dsi-ctrl"; > reg = <0x0ae94000 0x400>; > reg-names = "dsi_ctrl"; > -- With best wishes Dmitry