From: David Heidelberg <david@ixit.cz>
To: Mark Kettenis <mark.kettenis@xs4all.nl>,
Heiko Stuebner <heiko@sntech.de>
Cc: d3adme4t@gmail.com, macromorgan@hotmail.com, jbx6244@gmail.com,
f.kardame@manjaro.org, amadeus@jmu.edu.cn, robh+dt@kernel.org,
linux.amoon@gmail.com, aurelien@aurel32.net, anarsoul@gmail.com,
wiagn233@outlook.com, frattaroli.nicolas@gmail.com,
strit@manjaro.org, luiz.von.dentz@intel.com, zonyitoo@gmail.com,
wens@csie.org, jensenhuang@friendlyarm.com, lasstp5011@gmail.com,
frank-w@public-files.de, pgwipeout@gmail.com,
conor+dt@kernel.org, leo@nabam.net, andyshrk@163.com,
krzysztof.kozlowski+dt@linaro.org, michael.riesch@wolfvision.net,
jonas@kwiboo.se, festevam@denx.de, tobetter@gmail.com,
jagan@amarulasolutions.com, cnsztl@gmail.com,
cristian.ciocaltea@collabora.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property
Date: Mon, 10 Jul 2023 17:36:22 +0200 [thread overview]
Message-ID: <d117e562-424f-d128-fa81-41ec9022409f@ixit.cz> (raw)
In-Reply-To: <87wmz7q1fr.fsf@bloch.sibelius.xs4all.nl>
On 10/07/2023 16:35, Mark Kettenis wrote:
>> From: Heiko Stuebner <heiko@sntech.de>
>> Date: Mon, 10 Jul 2023 16:16:16 +0200
>>
>> On Fri, 7 Jul 2023 19:22:17 +0300, Cristian Ciocaltea wrote:
>>> The 'regulator-init-microvolt' property is not currently supported by
>>> any driver, it was simply carried on from downstream kernels.
>>>
>>> The problem is also indicated by the following dtbs_check warning:
>>>
>>> rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected)
>>>
>>> [...]
>> Applied, thanks!
>>
>> [1/1] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property
>> commit: 4d08b19629495b29601991d09d07865694c25199
> This property *is used* by the drivers in U-Boot. Dropping this from
> the Linux DTBs will likely result in broken boards the next time the
> U-Boot DTBs are synched again from Linux. At least that is what
> happened before...
Well, if u-boot uses these properties, u-boot folks should document them
in bindings ;-)
I found some u-boot mentions reviewing this patch, but only the DTS
files copied from Linux poped-up.
>
> I think the right solution is to add this property to the DT binding
> instead.
Sure, it should be sent together with the revert.
DT binding property description could also note that the bootloader(s)
use the value.
David
--
David Heidelberg
Consultant Software Engineer
next prev parent reply other threads:[~2023-07-10 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 16:22 [PATCH] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property Cristian Ciocaltea
2023-07-07 20:24 ` David Heidelberg
2023-07-10 7:43 ` AngeloGioacchino Del Regno
2023-07-10 14:16 ` Heiko Stuebner
2023-07-10 14:35 ` Mark Kettenis
2023-07-10 15:36 ` David Heidelberg [this message]
2023-07-10 15:39 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d117e562-424f-d128-fa81-41ec9022409f@ixit.cz \
--to=david@ixit.cz \
--cc=amadeus@jmu.edu.cn \
--cc=anarsoul@gmail.com \
--cc=andyshrk@163.com \
--cc=aurelien@aurel32.net \
--cc=cnsztl@gmail.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=d3adme4t@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.kardame@manjaro.org \
--cc=festevam@denx.de \
--cc=frank-w@public-files.de \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=jbx6244@gmail.com \
--cc=jensenhuang@friendlyarm.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lasstp5011@gmail.com \
--cc=leo@nabam.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=luiz.von.dentz@intel.com \
--cc=macromorgan@hotmail.com \
--cc=mark.kettenis@xs4all.nl \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=strit@manjaro.org \
--cc=tobetter@gmail.com \
--cc=wens@csie.org \
--cc=wiagn233@outlook.com \
--cc=zonyitoo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox