Re: [PATCH v6 1/2] dt-bindings: input: Add Qualcomm SPMI PMIC haptics

[Fenglin Wu <fenglin.wu@oss.qualcomm.com>]

On 8/7/2026 2:29 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Missing update to the parent PMIC schema `qcom,spmi-pmic.yaml` to allow the new `qcom,spmi-haptics` child node.
> --
> 
> --- Patch [1]: [PATCH v6 1/2] dt-bindings: input: Add Qualcomm SPMI PMIC haptics ---
> commit eb446753c24c30e9b557074281da814e0e94aa51
> Author: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
> 
> dt-bindings: input: Add Qualcomm SPMI PMIC haptics
> 
> Adds a device tree binding document for the haptics module inside the
> Qualcomm PMIC PMIH0108, which drives a Linear Resonant Actuator (LRA) and
> supports multiple play modes.
> 
>> diff --git a/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml b/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml
>> new file mode 100644
>> index 0000000000000..b1a69e9886ee6
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml
> 
> [ ... ]
> 
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> +    pmic {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        haptics@f000 {
>> +            compatible = "qcom,pmih0108-haptics", "qcom,spmi-haptics";
>> +            reg = <0xf000>, <0xf100>;
> 
> [Severity: Low]
> Does the parent PMIC schema (mfd/qcom,spmi-pmic.yaml) need to be updated to
> allow the new qcom,spmi-haptics child node shown in this example?
> 
> The parent PMIC schema has additionalProperties: false and explicitly lists
> allowed child node patterns in patternProperties. Since it does not include
> a pattern for ^haptics@[0-9a-f]+$, will device trees instantiating this
> haptics node fail dtbs_check validation?

The change which adds haptics child node in the spmi-pmic schema has
already been applied, so I dropped it in this series.

https://lore.kernel.org/linux-input/178602255123.2917765.7426706813083510078.b4-ty@b4/

> 
>> +            reg-names = "cfg", "ptn";
>> +            interrupts = <0x7 0xf0 0x1 IRQ_TYPE_EDGE_RISING>;
>> +            interrupt-names = "fifo-empty";
>> +
>> +            qcom,vmax-microvolt = <1300000>;
>> +            qcom,lra-period-us = <5880>;
>> +        };
>> +    };
>