From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2536F169AE6 for ; Tue, 29 Apr 2025 15:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745940370; cv=none; b=G0KBzHHuAkCzYJmsiE+oXwfXIuzUTgwGaST5po5R3fzMVEUvQr7aVsNyvFoNBmNEj09nzmBrqlj7KGOXp4RGyaIl5gs7ywr1f2RcDxJmSKc9u3JpuwjqsTaQaYFXELpgQgMgoTGoOpz084gv2XWTGEjbGllNiDZ22q9avpoJ43o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745940370; c=relaxed/simple; bh=PbCJ3eqOQPycfLIlHcU26eDZxIfwoDf/fUXtAYBciCo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YCumrw9HaC8xOGMa2CJFQIR+W10n8E0vFpFJFCzYI3yaPoUs+UE54BC0dUL+r8VBL7b5YQlU2153Esy4MzcFBuxMSqudiyGcUKwphkMkXuD/Oy+WJjm0GJFYqzj0vHaZhmWpKtw/jI22iOA/Gmbvf2ztzGgnt2e097PYE/fAzZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=YFWgNGCu; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="YFWgNGCu" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-2c76a1b574cso1716002fac.2 for ; Tue, 29 Apr 2025 08:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745940368; x=1746545168; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GqXd7CqxL691uVQllOCxYUhKwjtU/lcEe666k5nlk2E=; b=YFWgNGCuDJzAuYjkwp3iGbe5FAJSlS0Zx2buMafQnGo32fr+U91JKtzVgwxpRxlBCR HAgGPu4Qm3i8tyDZpjlfcxgVvsI1MHy+WaoSh63Oin+5o049xZV4CgeKHmbFIWueh0YR TX6/f+bDGE9pHzaBESadZBisTeSMj9/D3HhxHXvMFGmPWUDjyD+i4xcQBglz3e111Ucp QNA8Vs+27Yaw14uPqpJ5vI41xumCLL7vM4uUSAujIxc+yqVDTfun7RBUEjbqJV6pRa0X BMVw5HSL0D9aTMu8v20d5nNtTi0I9UlEd82CQSabmK6yA+KTGbhmg3TPrQat34lShRvG 4Jdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745940368; x=1746545168; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GqXd7CqxL691uVQllOCxYUhKwjtU/lcEe666k5nlk2E=; b=uxzGkL5oKZy5Mmyzt4saBou+nZwMUdu1hVtLydA7QZeIltnb36n91h4gTIUddpQej1 CGvNdW5vuZdcioO3RoHsGgD2Ojsa00zYSNbnls85sxAFTgfoCOimkO0PCMFUJ56AdgWO Ki42qw+H2yrQJG5jUXHshel+krZzmM8n/61ZsT7oyA2IUHDJ1omz0dc0BkcRLyKNRun8 ia1Ff9BIFxx+oM9XUpL7eolf6SL2YPQessVwJPVWtW/PTu9h50XHi027v34s690aDvHk p18Qc5foLMmZaOYx/JCd3ecsl7KA1SrFaNJE8puy0Ts2CI0xcEPn2+F1mOiCOeLsFcO0 oYXA== X-Forwarded-Encrypted: i=1; AJvYcCVk4Ixw0pYeZdsVagCwR8v34OID0y5ojf9vi9R8Rd9g92Eex2hb4mTsWrJTnIB7OvjxnoDTg0YPHs6y@vger.kernel.org X-Gm-Message-State: AOJu0YwCf80CoaVERaOsxXRA6KmcMRXP7Zpddns8ImYYisEmfr7TzF8l qrG/TDseAW+Bkgx2Rp0D9x0KnDbxIgpywWzsMV6dCnnKgSZl32nvw+6HLHCfIQM= X-Gm-Gg: ASbGncs2gURvVb5WmkXm3eKcOSBo8AVD3dwf4T2vD34a0N+WgfJ4Q2xggCzFE8gcydC 1Fkr23mYal/1rA4Cqk/5w7h9Vk6Bt/gPbmvRiz4cECXU0Cc8oYRa/3scSH1dIsir2Qbn5fLRQj7 SK1yAAdNSOoLfjwuqAD2onMOmZN7tFAWqRAQtcVApFadR/zTWRK1iIIog1yR2LXD2MoH8leWCvQ QCz28oxwmBEF/2NwmRzBKejyFS+RrtZucmvLXrYvzE/Ze0WncbPjkwzXP+YSg7iEV8H3c20z6lt Cwy7UPNrdj4BgdZaIq9xEK8iN9BZWI+nFM/Iwjv34P8ZN5XOFN3xs6XGuCXPTexgoBzZ+vLLhJk /RrUlxfVUBFkySsjWrQ== X-Google-Smtp-Source: AGHT+IFUp1czM56vFhnwCjOqwrL/S1Mh48QYvkOILNdjL8GS+rOj8cEaXcPSuTFNAk6VzZ0KfdpCgg== X-Received: by 2002:a05:6870:d68a:b0:29e:2ce2:94d with SMTP id 586e51a60fabf-2d9be53d02cmr7495407fac.14.1745940368204; Tue, 29 Apr 2025 08:26:08 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:dc17:157d:e8b2:3ad6? ([2600:8803:e7e4:1d00:dc17:157d:e8b2:3ad6]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2d973b794e2sm2841412fac.40.2025.04.29.08.26.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 08:26:06 -0700 (PDT) Message-ID: Date: Tue, 29 Apr 2025 10:26:05 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] dt-bindings: iio: adc: adi,ad7606: add gain calibration support To: Angelo Dureghello , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20250429-wip-bl-ad7606-calibration-v1-0-eb4d4821b172@baylibre.com> <20250429-wip-bl-ad7606-calibration-v1-4-eb4d4821b172@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: <20250429-wip-bl-ad7606-calibration-v1-4-eb4d4821b172@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/29/25 8:06 AM, Angelo Dureghello wrote: > From: Angelo Dureghello > > Add gain calibration support by a per-channel resistor value. > > Signed-off-by: Angelo Dureghello > --- > Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml > index 29f12d650442b8ff2eb455306ce59a0e87867ddd..df30545fb52c89a814257443183303775a06a7f2 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml > @@ -204,6 +204,15 @@ patternProperties: > considered a bipolar differential channel. Otherwise it is bipolar > single-ended. > > + adi,rfilter-ohms: > + description: > + For ADCs that supports gain calibration, this property must be set to > + the value of the external RFilter resistor. Proper gain error > + correction is applied based on this value. > + default: 0 > + minimum: 0 > + maximum: 65536 > + > required: > - reg > - bipolar > @@ -271,6 +280,10 @@ allOf: > then: > properties: > adi,sw-mode: false > + patternProperties: > + "^channel@[0-9a-f]+$": > + properties: > + adi,rfilter-ohms: false I think this is in the wrong place. It would allow this property on ad7616, but ad7616 does not have this feature. > else: > properties: > pwms: > @@ -398,6 +411,7 @@ examples: > reg = <8>; > diff-channels = <8 8>; > bipolar; > + adi,rfilter-ohms = <2048>; > }; > > }; >