From: Marek Vasut <marex@denx.de>
To: Lucas Stach <l.stach@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Paul Elder <paul.elder@ideasonboard.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 07/11] soc: imx: add i.MX8MP HDMI blk-ctrl
Date: Thu, 7 Apr 2022 01:56:26 +0200 [thread overview]
Message-ID: <d14e4aa1-f70f-decd-a078-9ffc80caa584@denx.de> (raw)
In-Reply-To: <20220406153402.1265474-8-l.stach@pengutronix.de>
On 4/6/22 17:33, Lucas Stach wrote:
[...]
> +static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc,
> + struct imx8mp_blk_ctrl_domain *domain)
> +{
> + switch (domain->id) {
> + case IMX8MP_HDMIBLK_PD_IRQSTEER:
> + regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL0, BIT(9));
> + regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, BIT(16));
> + break;
> + case IMX8MP_HDMIBLK_PD_LCDIF:
> + regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL0,
> + BIT(7) | BIT(16) | BIT(17) | BIT(18) |
> + BIT(19) | BIT(20));
> + regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(11));
> + regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0,
> + BIT(4) | BIT(5) | BIT(6));
Macros which define all those ad-hoc bits might be nice.
[...]
next prev parent reply other threads:[~2022-04-07 0:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 15:33 [PATCH v4 00/11] consolidated i.MX8MP HSIO/MEDIA/HDMI blk-ctrl series Lucas Stach
2022-04-06 15:33 ` [PATCH v4 01/11] soc: imx: imx8m-blk-ctrl: set power device name Lucas Stach
2022-04-25 21:28 ` Laurent Pinchart
2022-04-06 15:33 ` [PATCH v4 02/11] soc: imx: add i.MX8MP HSIO blk-ctrl Lucas Stach
2022-04-06 23:43 ` Marek Vasut
2022-04-07 9:12 ` Lucas Stach
2022-04-10 22:11 ` Marek Vasut
2022-04-11 16:46 ` Lucas Stach
2022-04-11 22:25 ` Marek Vasut
2022-04-06 15:33 ` [PATCH v4 03/11] dt-bindings: soc: Add i.MX8MP media block control DT bindings Lucas Stach
2022-05-09 12:39 ` Rob Herring
2022-05-10 19:59 ` Laurent Pinchart
2022-04-06 15:33 ` [PATCH v4 04/11] soc: imx: imx8m-blk-ctrl: Add i.MX8MP media blk-ctrl Lucas Stach
2022-04-06 15:33 ` [PATCH v4 05/11] dt-bindings: power: imx8mp: add defines for HDMI blk-ctrl domains Lucas Stach
2022-04-13 18:35 ` Rob Herring
2022-04-06 15:33 ` [PATCH v4 06/11] dt-bindings: soc: add binding for i.MX8MP HDMI blk-ctrl Lucas Stach
2022-04-13 18:37 ` Rob Herring
2022-04-06 15:33 ` [PATCH v4 07/11] soc: imx: add " Lucas Stach
2022-04-06 23:56 ` Marek Vasut [this message]
2022-04-06 15:33 ` [PATCH v4 08/11] arm64: dts: imx8mp: add HSIO power-domains Lucas Stach
2022-04-06 15:34 ` [PATCH v4 09/11] arm64: dts: imx8mp: Add MEDIAMIX power domains Lucas Stach
2022-04-06 15:34 ` [PATCH v4 10/11] arm64: dts: imx8mp: Add MEDIA_BLK_CTRL Lucas Stach
2022-04-06 15:34 ` [PATCH v4 11/11] arm64: dts: imx8mp: add HDMI power-domains Lucas Stach
2022-05-04 8:27 ` [PATCH v4 00/11] consolidated i.MX8MP HSIO/MEDIA/HDMI blk-ctrl series Lucas Stach
2022-05-04 8:48 ` Laurent Pinchart
2022-05-04 8:56 ` Lucas Stach
2022-05-04 10:08 ` Laurent Pinchart
2022-05-04 10:19 ` Marek Vasut
2022-05-05 1:38 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d14e4aa1-f70f-decd-a078-9ffc80caa584@denx.de \
--to=marex@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=paul.elder@ideasonboard.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).