From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6CECC43334 for ; Mon, 18 Jul 2022 13:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235421AbiGRN61 (ORCPT ); Mon, 18 Jul 2022 09:58:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232836AbiGRN61 (ORCPT ); Mon, 18 Jul 2022 09:58:27 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAE2527FDF for ; Mon, 18 Jul 2022 06:58:25 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id x10so13235016ljj.11 for ; Mon, 18 Jul 2022 06:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=scDNluyl3Sc3xGeqgTfNYZogBEUOOlaQnjVhvnH1aKQ=; b=LWRdlN3Qf31EcZGv0pnKMXuD8WmWanUevmoH/VV4mhnGAvFytZSZUD+9dTSWms+JkZ N+K9p6Khl9Z0OVVT1i0H3sl+uvv/aF2a1r8ATUk5tYG7Q4JtM+okhG2FUUA8DclMfDpm SySuuICQU2cM1v4B5wApQIhdzzFgYAYxnm7UxQGJwa+u0GqeIR8Tl3yajLl6iiVq6E3F xmMNFceC1nCym4z9xVPxTPBzzyfLBayKrG/MipLIBb25CZWZujsrDRJqxxiht6xfQ6T2 8qbNWnbnzUtzpxxtbLQGlyADkv01v6HpVbWhbFK8lrSCES4ArJ04dKUW+Oxb8ifmSZh9 YkWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=scDNluyl3Sc3xGeqgTfNYZogBEUOOlaQnjVhvnH1aKQ=; b=twylZKzS2z+W3SagHMfKN2EpH4sscN9IxeK54yd24hlhall+3sTmo+NOoY6sVVadBL G1xfl+1eyzMtatfXj2TjnbCVeAYXkJTLIsjoAo5/KNBIwHIPYbCV/uVtSlgqrxnClho1 /kCNF1ano3/PXElbwq4yRMLIw4EXZLFCpSeavNgSb752pRBw0ysPF76ak6YeNpjTJKcH WagMh5DKxJ6tmChSv2yacPap8awg1RceyHVSkK0Z07jPWoM3hx6U7UfoauDZzaOyexXI gjoqU+Hk0OHdxOucjVTbUblbNCcZ4d00SnuahH/c7hpCSlB16R9Fw8clTDe307iehGuw f1PQ== X-Gm-Message-State: AJIora8YR2t6Fz/OWoQh1GQ/kk3QsoGsyIcNWjYQxLNqw5eCbm1wmZyA C864slZ5+HVC/1haYJGAU1UIBw== X-Google-Smtp-Source: AGRyM1s7BZkKPvkYka27fRjzNLHeDCKrCHSSUZBaMaOwtazGYvyslxTkViMRRHwXDwYuRAlGKPKJUg== X-Received: by 2002:a2e:895a:0:b0:25d:6815:98ff with SMTP id b26-20020a2e895a000000b0025d681598ffmr11998753ljk.189.1658152704119; Mon, 18 Jul 2022 06:58:24 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id m7-20020a056512114700b0047a0300746fsm2609261lfg.304.2022.07.18.06.58.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jul 2022 06:58:23 -0700 (PDT) Message-ID: Date: Mon, 18 Jul 2022 15:58:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 2/2] dt-bindings: fpga: add binding doc for ecp5-spi fpga mgr Content-Language: en-US To: Ivan Bornyakov , mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, system@metrotek.ru References: <20220718114928.22092-1-i.bornyakov@metrotek.ru> <20220718114928.22092-3-i.bornyakov@metrotek.ru> From: Krzysztof Kozlowski In-Reply-To: <20220718114928.22092-3-i.bornyakov@metrotek.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/07/2022 13:49, Ivan Bornyakov wrote: > Add Device Tree Binding doc for Lattice ECP5 FPGA manager using slave > SPI to load .bit formatted uncompressed bitstream image. > > Signed-off-by: Ivan Bornyakov > --- > .../bindings/fpga/lattice,ecp5-fpga-mgr.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml > > diff --git a/Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml > new file mode 100644 > index 000000000000..bb10fd316f94 > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/fpga/lattice,ecp5-fpga-mgr.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lattice ECP5 Slave SPI FPGA manager. > + > +maintainers: > + - Ivan Bornyakov > + > +description: > + FPGA Manager capable to program Lattice ECP5 with uncompressed bitstream > + image in .bit format over SPI. The same question as before - you need to explain what is the hardware (not Linux API or Linux subsystem). > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml > + > +properties: > + reg: > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 60000000 > + > + compatible: > + enum: > + - lattice,ecp5-fpga-mgr Compatible goes first in the list of properties. Change here was not requested, so I am surprised to see different coding style. > + > + program-gpios: > + description: > + A GPIO line connected to PROGRAMN (active low) pin of the device. > + Initiates configuration sequence. > + maxItems: 1 > + > + init-gpios: > + description: > + A GPIO line connected to INITN (active low) pin of the device. > + Indicates that the FPGA is ready to be configured. > + maxItems: 1 > + > + done-gpios: > + description: > + A GPIO line connected to DONE (active high) pin of the device. > + Indicates that the configuration sequence is complete. > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - program-gpios > + - init-gpios > + - done-gpios > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + fpga-mgr@0 { > + compatible = "lattice,ecp5-fpga-mgr"; > + spi-max-frequency = <20000000>; > + reg = <0>; compatible then reg, then rest of properties. Best regards, Krzysztof