From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: list@c-mauderer.de, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Christian Mauderer <oss@c-mauderer.de>
Subject: Re: [PATCH 1/2] dt-bindings: leds: Add binding for ubnt-spi LED.
Date: Sat, 4 May 2019 21:45:41 +0200 [thread overview]
Message-ID: <d1704398-ae90-b4e8-50d3-f9533d94ab2b@gmail.com> (raw)
In-Reply-To: <4889e87a-5c7a-da74-bff6-c20fd07ea0f4@gmail.com>
I missed two issues, please take a look below.
> On 5/4/19 2:28 PM, list@c-mauderer.de wrote:
>> From: Christian Mauderer <oss@c-mauderer.de>
>>
[...]
>> +- ubnt-spi,max_bright: Value for the maximum brightness. Default
From DT POV the only valid reason for which max brightness level would
need to be limited is a protection against hardware damage. Please use
led-max-microamp property for that if this is the case. Otherwise such
setting can be skipped.
There are two bindings that allow for configuring max-brightness level
but they quite old.
>> value for that
>> + is 63.
>> +- label: A label for the LED. If one is given, the LED will be
>> + named "ubnt-spi:<label>" or "ubnt-spi::" otherwise.
>> +
Please use just:
label : see Documentation/devicetree/bindings/leds/common.txt
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-05-04 19:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 12:28 [PATCH 1/2] dt-bindings: leds: Add binding for ubnt-spi LED list
2019-05-04 12:28 ` [PATCH 2/2] leds: ubnt-spi: Add Ubnt AirCube ISP LED driver list
2019-05-04 16:20 ` Pavel Machek
2019-05-04 16:43 ` Christian Mauderer
2019-05-04 17:25 ` Pavel Machek
2019-05-04 16:12 ` [PATCH 1/2] dt-bindings: leds: Add binding for ubnt-spi LED Pavel Machek
2019-05-04 16:46 ` Christian Mauderer
2019-05-04 19:34 ` Jacek Anaszewski
2019-05-04 19:45 ` Jacek Anaszewski [this message]
2019-05-04 20:01 ` Christian Mauderer
2019-05-04 20:07 ` Jacek Anaszewski
2019-05-04 19:48 ` Christian Mauderer
2019-05-04 20:01 ` Jacek Anaszewski
2019-05-04 20:34 ` Pavel Machek
2019-05-04 22:17 ` Pavel Machek
2019-05-05 8:01 ` Christian Mauderer
2019-05-05 10:56 ` Jacek Anaszewski
2019-05-05 11:51 ` Christian Mauderer
2019-05-05 12:15 ` Jacek Anaszewski
2019-05-05 11:54 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1704398-ae90-b4e8-50d3-f9533d94ab2b@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=list@c-mauderer.de \
--cc=mark.rutland@arm.com \
--cc=oss@c-mauderer.de \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).