From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Yu Subject: Re: [PATCH v3 07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Date: Mon, 4 Mar 2019 10:37:20 +0800 Message-ID: References: <20190302090505.65542-1-chenyu56@huawei.com> <20190302090505.65542-8-chenyu56@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: liuyu712@hisilicon.com, USB , devicetree , Linux Kernel Mailing List , John Stultz , Suzhuangluan , Kongfei , wanghu17@hisilicon.com, butao@hisilicon.com, Yao Chen , fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei , xu yiping , xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Kishon Vijay Abraham I , "David S. Miller" , Greg Kroah-Hartman , Mauro Carvalho Chehab , Andrew Morton List-Id: devicetree@vger.kernel.org Hi Andy, On 2019/3/2 23:56, Andy Shevchenko wrote: > On Sat, Mar 2, 2019 at 11:06 AM Yu Chen wrote: >> >> This driver handles usb phy power on and shutdown for hi3660 Soc of >> Hisilicon. > > Few comments below. After fixing them, FWIW > Reviewed-by: Andy Shevchenko > >> +#define HI3660_USB_DEFAULT_PHY_PARAM 0x1c466e3 > > A bit of description would be nice to have what this value means. > OK. >> + /* delay for exit from IDDQ mode */ >> + usleep_range(100, 100); > > 100,100 ? I think you need to give a room to scheduler, at least 20% > margin would be good to have. > >> + /* delay for vbus valid */ >> + usleep_range(100, 100); > > Ditto. > > OK. Thanks Yu Chen