From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2EFAC7EE2A for ; Tue, 6 Jun 2023 06:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234736AbjFFGOk (ORCPT ); Tue, 6 Jun 2023 02:14:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232906AbjFFGOj (ORCPT ); Tue, 6 Jun 2023 02:14:39 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1318A100 for ; Mon, 5 Jun 2023 23:14:38 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5149e65c218so8566925a12.2 for ; Mon, 05 Jun 2023 23:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686032076; x=1688624076; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c9/ke8vQiyBtX+dMh7jOybxE1aXL3oACs0/tXuO+L4U=; b=eWY5hKNC6JKDtcg4koedkUquXkdz4Qm7ioMxMxeSjG40XG3NTMTnzK7wOpWQfTHpZM 3UipQrboWk2BEtNpxv9nzlw7CkPmQzMREcltPyxNq7b+1A48GKNiLAYrDYMQDD2CxpgU jKFLfBUWdm1nlGtj5XilnON1j3BW3L0Vfde6K1BcsaaJAHUoDPUCrwiygj+BBINUFoQG +mfNC3eVh7aFzeMtwa4CM0CjLBCegI8dvl1QgNKPSF62tBw2cUrpCPzE92UTSO/rWrSD vKVw291npS8n956cbRw5LDbVtiwsemu4h3S1VOup36wy3m1ZJpmQpb1Djcf4XRP2IgbL Tq5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686032076; x=1688624076; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c9/ke8vQiyBtX+dMh7jOybxE1aXL3oACs0/tXuO+L4U=; b=dek6w1u9v1OIImELBcx22m2t7zemVvpYLgRa76mCE6BZ7MAQKkYr0EF1w1nRGX+QOH tDII3+z4NMBncyMzgW+rSmnImZXa9HlbvcZZiTWH4oKsIIwJhHidsvnQZuwlz3H6h+Oo zBOqiHoV+u3V6TnU/f7ps1yYb+h+rJ/cnESf3keEBv/u0+YCEy+4tSXgPn5SmMLawRrc q9PhbBuGpCJ7EQPVYux3yR48xyDu139YSLltqCWz3VLB822SEhmee9rsdxsVeG6FSeiD Z8JcgjYGowuXfUC6XIrW+u1wwWg/ysdCuPFhaZc/TtNZkFAMrJ5smUU1fhC4WeeIANNf r26g== X-Gm-Message-State: AC+VfDyIgNYnznB5BJFwmmIqFyOviZiSrvuqn544Xlm6CcTyY1uRmeGP 2A3VzuGeCjXzhT0CDmS4RIDThg== X-Google-Smtp-Source: ACHHUZ64Z9lKKWilVnf6tdOypQFOM3iC4izULYvUu+KGcG0PYJwTnO62ZR0THx9JxKoLkPlyBtVhVA== X-Received: by 2002:aa7:d3c3:0:b0:516:4394:244f with SMTP id o3-20020aa7d3c3000000b005164394244fmr954905edr.12.1686032076496; Mon, 05 Jun 2023 23:14:36 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s25-20020aa7c559000000b005163c39645bsm4672584edr.51.2023.06.05.23.14.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 23:14:36 -0700 (PDT) Message-ID: Date: Tue, 6 Jun 2023 08:14:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH V2 01/13] dt-bindings: remoteproc: qcom: Add support for multipd model Content-Language: en-US To: Manikanta Mylavarapu , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jassisinghbrar@gmail.com, mathieu.poirier@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, quic_eberman@quicinc.com, quic_mojha@quicinc.com, kvalo@kernel.org, loic.poulain@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-clk@vger.kernel.org Cc: quic_srichara@quicinc.com, quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com, quic_anusha@quicinc.com, quic_poovendh@quicinc.com, quic_varada@quicinc.com, quic_devipriy@quicinc.com References: <20230521222852.5740-1-quic_mmanikan@quicinc.com> <20230521222852.5740-2-quic_mmanikan@quicinc.com> <7940c743-815f-f864-d015-43d7e916ecfa@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/06/2023 14:02, Manikanta Mylavarapu wrote: >>> + memory-region: >>> + items: >>> + - description: Q6 pd reserved region >>> + >>> + glink-edge: >>> + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# >>> + description: >>> + Qualcomm G-Link subnode which represents communication edge, channels >>> + and devices related to the Modem. >>> + >>> +patternProperties: >>> + "^pd-1|pd-2|pd-3": >>> + type: object >>> + description: >>> + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be up before >>> + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 >>> + device node. >> >> That's not enough. Your description does not say what is this, why you >> have two protection domains for same compatible. What's more, it a bit >> deviates from hardware description. >> > WCSS means 'wireless connectivity sub system', in simple words it's a > wifi radio block. > > IPQ5018 SOC has both internal (AHB) wifi radio/WCSS and external (PCIE) > wifi radio/WCSS. In Q6, Root protection domain will provide services to > both internal (AHB) and external (PCIE) wifi radio's protection domain. > So we have two protection domains for IPQ5018, one is for internal(AHB) > and other is for external(PCIE) wifi radio. So it is now in email, but not in the code... > >>> + >>> + properties: >>> + compatible: >>> + enum: >>> + - qcom,ipq5018-wcss-ahb-mpd >>> + - qcom,ipq9574-wcss-ahb-mpd >>> + - qcom,ipq5018-wcss-pcie-mpd >> >> Keep rather alphabetical order (so both 5018 together). >> >> I also do not understand these at all. Why adding bus type to >> compatible? This rarely is allowed (unless it is PCIe controller within >> soc). >> > IPQ5018 SOC has in-built PCIE controller. Here QDSP6 will bring up > external(PCIE) and internal (AHB) wifi radio's. To separate AHB, PCIE > radio's properties, i have added bus type to compatible. It's the same device - WCSS - right? We do not create multiple nodes and compatibles for the same devices. Bus suffixes are almost never parts of compatibles. >> >> Drop. >> >>> + >>> +unevaluatedProperties: false >> >> This changed... why? >> >> > 'unevaluatedProperties' is similar to 'additionalProperties' except > that it recognize properties declared in subschemas as well. You don't have to explain me what are unevaluatedProperties or additionalProperties. Let's assume that I know them. What you should explain is why you changed it. Where is the reference to other schema? Best regards, Krzysztof