From: Florian Fainelli <f.fainelli@gmail.com>
To: Ariel D'Alessandro <ariel.dalessandro@collabora.com>,
Peter Robinson <pbrobinson@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
gkrzysztof.kozlowski+dt@linaro.org, gnsaenz@kernel.org,
grobh+dt@kernel.org, nsaenz@kernel.org, stefan.wahren@i2se.com
Subject: Re: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index
Date: Mon, 13 Jun 2022 16:34:12 -0700 [thread overview]
Message-ID: <d18e93a0-f2d7-81c6-56e8-9dfbc6f14383@gmail.com> (raw)
In-Reply-To: <f83690bb-5513-db87-2d97-7cbd981aa0f7@collabora.com>
On 6/13/22 05:46, Ariel D'Alessandro wrote:
> Hi Peter,
>
> On 6/12/22 17:38, Peter Robinson wrote:
>> On Wed, Jun 8, 2022 at 1:35 PM Ariel D'Alessandro
>> <ariel.dalessandro@collabora.com> wrote:
>>>
>>> Add MMC aliases to ensure that the /dev/mmcblk ID for SD card won't
>>> change depending on the probe order of the MMC drivers.
>>
>> Is the bcm2711-rpi.dtsi a better place for it given there's other
>> aliases there and it will be consistent across variations?
>
> Yes, indeed, it makes sense moving it to bcm2711-rpi.dtsi
>
> The other board what will be affected by this alias is the Raspberry Pi
> Compute Module 4 IO Board, on which emmc2 is the eMMC. However, the
> alias makes sense, to have that as the first mmc device.
>
> Maybe we can add the alias as follows?
>
> mmc0 = &emmc2; /* mmcblk0 for eMMC/SD */
You have made a typo on the bcm-kernel-feedback-list meaning that this
won't reach the patchwork instance I use to manage and apply patches,
can you please fix that up for your v2? Thanks!
--
Florian
next prev parent reply other threads:[~2022-06-13 23:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 12:32 [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index Ariel D'Alessandro
2022-06-12 20:38 ` Peter Robinson
2022-06-13 12:46 ` Ariel D'Alessandro
2022-06-13 23:34 ` Florian Fainelli [this message]
2022-06-14 6:34 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d18e93a0-f2d7-81c6-56e8-9dfbc6f14383@gmail.com \
--to=f.fainelli@gmail.com \
--cc=ariel.dalessandro@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=gkrzysztof.kozlowski+dt@linaro.org \
--cc=gnsaenz@kernel.org \
--cc=grobh+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenz@kernel.org \
--cc=pbrobinson@gmail.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).