* [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index
@ 2022-06-08 12:32 Ariel D'Alessandro
2022-06-12 20:38 ` Peter Robinson
0 siblings, 1 reply; 5+ messages in thread
From: Ariel D'Alessandro @ 2022-06-08 12:32 UTC (permalink / raw)
To: devicetree, linux-arm-kernel, linux-kernel, linux-rpi-kernel
Cc: gbcm-kernel-feedback-list, gkrzysztof.kozlowski+dt, gnsaenz,
grobh+dt
Add MMC aliases to ensure that the /dev/mmcblk ID for SD card won't
change depending on the probe order of the MMC drivers.
Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
---
arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
index 4432412044de..780812542bad 100644
--- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
+++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
@@ -14,6 +14,10 @@ chosen {
stdout-path = "serial1:115200n8";
};
+ aliases {
+ mmc0 = &emmc2; /* mmcblk0 for SD */
+ };
+
leds {
led-act {
gpios = <&gpio 42 GPIO_ACTIVE_HIGH>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index
2022-06-08 12:32 [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index Ariel D'Alessandro
@ 2022-06-12 20:38 ` Peter Robinson
2022-06-13 12:46 ` Ariel D'Alessandro
0 siblings, 1 reply; 5+ messages in thread
From: Peter Robinson @ 2022-06-12 20:38 UTC (permalink / raw)
To: Ariel D'Alessandro
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
gbcm-kernel-feedback-list, gkrzysztof.kozlowski+dt, gnsaenz,
grobh+dt
On Wed, Jun 8, 2022 at 1:35 PM Ariel D'Alessandro
<ariel.dalessandro@collabora.com> wrote:
>
> Add MMC aliases to ensure that the /dev/mmcblk ID for SD card won't
> change depending on the probe order of the MMC drivers.
Is the bcm2711-rpi.dtsi a better place for it given there's other
aliases there and it will be consistent across variations?
> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
> ---
> arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> index 4432412044de..780812542bad 100644
> --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> @@ -14,6 +14,10 @@ chosen {
> stdout-path = "serial1:115200n8";
> };
>
> + aliases {
> + mmc0 = &emmc2; /* mmcblk0 for SD */
> + };
> +
> leds {
> led-act {
> gpios = <&gpio 42 GPIO_ACTIVE_HIGH>;
> --
> 2.34.1
>
>
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index
2022-06-12 20:38 ` Peter Robinson
@ 2022-06-13 12:46 ` Ariel D'Alessandro
2022-06-13 23:34 ` Florian Fainelli
0 siblings, 1 reply; 5+ messages in thread
From: Ariel D'Alessandro @ 2022-06-13 12:46 UTC (permalink / raw)
To: Peter Robinson
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
gbcm-kernel-feedback-list, gkrzysztof.kozlowski+dt, gnsaenz,
grobh+dt, nsaenz, stefan.wahren
Hi Peter,
On 6/12/22 17:38, Peter Robinson wrote:
> On Wed, Jun 8, 2022 at 1:35 PM Ariel D'Alessandro
> <ariel.dalessandro@collabora.com> wrote:
>>
>> Add MMC aliases to ensure that the /dev/mmcblk ID for SD card won't
>> change depending on the probe order of the MMC drivers.
>
> Is the bcm2711-rpi.dtsi a better place for it given there's other
> aliases there and it will be consistent across variations?
Yes, indeed, it makes sense moving it to bcm2711-rpi.dtsi
The other board what will be affected by this alias is the Raspberry Pi
Compute Module 4 IO Board, on which emmc2 is the eMMC. However, the
alias makes sense, to have that as the first mmc device.
Maybe we can add the alias as follows?
mmc0 = &emmc2; /* mmcblk0 for eMMC/SD */
Regards,
Ariel
>
>> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
>> ---
>> arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
>> index 4432412044de..780812542bad 100644
>> --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
>> +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
>> @@ -14,6 +14,10 @@ chosen {
>> stdout-path = "serial1:115200n8";
>> };
>>
>> + aliases {
>> + mmc0 = &emmc2; /* mmcblk0 for SD */
>> + };
>> +
>> leds {
>> led-act {
>> gpios = <&gpio 42 GPIO_ACTIVE_HIGH>;
>> --
>> 2.34.1
>>
>>
>> _______________________________________________
>> linux-rpi-kernel mailing list
>> linux-rpi-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index
2022-06-13 12:46 ` Ariel D'Alessandro
@ 2022-06-13 23:34 ` Florian Fainelli
2022-06-14 6:34 ` Stefan Wahren
0 siblings, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2022-06-13 23:34 UTC (permalink / raw)
To: Ariel D'Alessandro, Peter Robinson
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
gkrzysztof.kozlowski+dt, gnsaenz, grobh+dt, nsaenz, stefan.wahren
On 6/13/22 05:46, Ariel D'Alessandro wrote:
> Hi Peter,
>
> On 6/12/22 17:38, Peter Robinson wrote:
>> On Wed, Jun 8, 2022 at 1:35 PM Ariel D'Alessandro
>> <ariel.dalessandro@collabora.com> wrote:
>>>
>>> Add MMC aliases to ensure that the /dev/mmcblk ID for SD card won't
>>> change depending on the probe order of the MMC drivers.
>>
>> Is the bcm2711-rpi.dtsi a better place for it given there's other
>> aliases there and it will be consistent across variations?
>
> Yes, indeed, it makes sense moving it to bcm2711-rpi.dtsi
>
> The other board what will be affected by this alias is the Raspberry Pi
> Compute Module 4 IO Board, on which emmc2 is the eMMC. However, the
> alias makes sense, to have that as the first mmc device.
>
> Maybe we can add the alias as follows?
>
> mmc0 = &emmc2; /* mmcblk0 for eMMC/SD */
You have made a typo on the bcm-kernel-feedback-list meaning that this
won't reach the patchwork instance I use to manage and apply patches,
can you please fix that up for your v2? Thanks!
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index
2022-06-13 23:34 ` Florian Fainelli
@ 2022-06-14 6:34 ` Stefan Wahren
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Wahren @ 2022-06-14 6:34 UTC (permalink / raw)
To: Ariel D'Alessandro, Peter Robinson
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
gkrzysztof.kozlowski+dt, gnsaenz, grobh+dt, nsaenz,
Florian Fainelli
Am 14.06.22 um 01:34 schrieb Florian Fainelli:
> On 6/13/22 05:46, Ariel D'Alessandro wrote:
>> Hi Peter,
>>
>> On 6/12/22 17:38, Peter Robinson wrote:
>>> On Wed, Jun 8, 2022 at 1:35 PM Ariel D'Alessandro
>>> <ariel.dalessandro@collabora.com> wrote:
>>>>
>>>> Add MMC aliases to ensure that the /dev/mmcblk ID for SD card won't
>>>> change depending on the probe order of the MMC drivers.
>>>
>>> Is the bcm2711-rpi.dtsi a better place for it given there's other
>>> aliases there and it will be consistent across variations?
>>
>> Yes, indeed, it makes sense moving it to bcm2711-rpi.dtsi
>>
>> The other board what will be affected by this alias is the Raspberry Pi
>> Compute Module 4 IO Board, on which emmc2 is the eMMC. However, the
>> alias makes sense, to have that as the first mmc device.
>>
>> Maybe we can add the alias as follows?
>>
>> mmc0 = &emmc2; /* mmcblk0 for eMMC/SD */
>
> You have made a typo on the bcm-kernel-feedback-list meaning that this
> won't reach the patchwork instance I use to manage and apply patches,
> can you please fix that up for your v2? Thanks!
Not just the bcm-kernel-feedback-list is affected, also the address of
Krzysztof, Rob and Nicolas has a g prepended.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-14 6:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-08 12:32 [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index Ariel D'Alessandro
2022-06-12 20:38 ` Peter Robinson
2022-06-13 12:46 ` Ariel D'Alessandro
2022-06-13 23:34 ` Florian Fainelli
2022-06-14 6:34 ` Stefan Wahren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).