From: Wesley Cheng <wcheng@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org, kishon@ti.com,
robh+dt@kernel.org, mark.rutland@arm.com, p.zabel@pengutronix.de,
mgautam@codeaurora.org, vkoul@kernel.org, sboyd@kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, jackp@codeaurora.org
Subject: Re: [PATCH v8 1/5] dt-bindings: phy: Add binding for qcom,usb-snps-femto-v2
Date: Tue, 5 May 2020 12:38:26 -0700 [thread overview]
Message-ID: <d1b6c7f2-69d8-027d-267d-22018484441e@codeaurora.org> (raw)
In-Reply-To: <20200505133408.GA24731@bogus>
On 5/5/2020 6:34 AM, Rob Herring wrote:
> On Mon, 4 May 2020 16:54:23 -0700, Wesley Cheng wrote:
>> This binding shows the descriptions and properties for the
>> Synopsis Femto USB PHY V2 used on QCOM platforms.
>>
>> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
>> ---
>> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 77 ++++++++++++++++++++++
>> 1 file changed, 77 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda-pll-supply' is a required property
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda18-supply' is a required property
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda33-supply' is a required property
>
> See https://patchwork.ozlabs.org/patch/1283143
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>
> Please check and re-submit.
>
Hi Rob,
I updated the dt-schema version, and I can see the same error. Will fix
and resubmit. I also realized that the dt_binding_check doesn't stop if
errors are detected in the example DT checking phase, and that was
probably why I missed this initially. I'll pass the DT_SCHEMA_FILES
argument to my specific binding next time to help verify my file.
Thanks again!
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-05-05 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 23:54 [PATCH v8 0/5] Add SS/HS-USB changes for Qualcomm SM8150 chipset Wesley Cheng
2020-05-04 23:54 ` [PATCH v8 1/5] dt-bindings: phy: Add binding for qcom,usb-snps-femto-v2 Wesley Cheng
2020-05-05 13:34 ` Rob Herring
2020-05-05 19:38 ` Wesley Cheng [this message]
2020-05-06 4:17 ` Vinod Koul
2020-05-04 23:54 ` [PATCH v8 2/5] phy: qcom-snps: Add SNPS USB PHY driver for QCOM based SOCs Wesley Cheng
2020-05-04 23:54 ` [PATCH v8 3/5] phy: qcom-qmp: Add SM8150 QMP USB3 PHY support Wesley Cheng
2020-05-04 23:54 ` [PATCH v8 4/5] phy: qcom-qmp: Use proper PWRDOWN offset for sm8150 USB Wesley Cheng
2020-05-04 23:54 ` [PATCH v8 5/5] phy: qcom-qmp: Rename UFS PCS QMP v4 registers Wesley Cheng
2020-05-05 5:14 ` [PATCH v8 0/5] Add SS/HS-USB changes for Qualcomm SM8150 chipset Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1b6c7f2-69d8-027d-267d-22018484441e@codeaurora.org \
--to=wcheng@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jackp@codeaurora.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).