From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C02B2C433DB for ; Mon, 22 Mar 2021 13:21:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 813EA6197F for ; Mon, 22 Mar 2021 13:21:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229829AbhCVNVF (ORCPT ); Mon, 22 Mar 2021 09:21:05 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:59878 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232316AbhCVNTO (ORCPT ); Mon, 22 Mar 2021 09:19:14 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1616419154; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Q/r41fIqJ2Y9Toafnn95hP48WRb+YnexiUA7BrVZA/o=; b=LMw98UzCoLHWtk6hMdfC8wNLboVxNJPvGH714mSVKFMXq8OxtuvmRp5sv7cDwAYXYlWaGDMQ j7Z2DcGaa6AQHFQy5mNPNy6FAoH89mC38MmCfKeHlCAv2t8ypPTsW6nUVITObtlqAXBtD6HW vr/p4pfzfqfQnHoyw5uD19vMmwE= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 605899354db3bb6801285cb4 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 22 Mar 2021 13:18:45 GMT Sender: skakit=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D44EEC4347C; Mon, 22 Mar 2021 13:18:44 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: skakit) by smtp.codeaurora.org (Postfix) with ESMTPSA id 66DEEC4347C; Mon, 22 Mar 2021 13:18:43 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 22 Mar 2021 18:48:43 +0530 From: skakit@codeaurora.org To: Bjorn Andersson Cc: Rob Herring , Andy Gross , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kgunda@codeaurora.org Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280 In-Reply-To: References: <1615459229-27573-1-git-send-email-skakit@codeaurora.org> Message-ID: X-Sender: skakit@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Bjorn, On 2021-03-12 23:06, Bjorn Andersson wrote: > On Thu 11 Mar 04:40 CST 2021, satya priya wrote: > >> Add PM7325/PM8350C/PMK8350/PMR735A peripherals such as PON, >> GPIOs, RTC and other PMIC infra modules for SC7280. >> > > Overall this looks good, just two small things below. > >> Signed-off-by: satya priya >> --- >> This patch depends on base DT and board files for SC7280 to merge >> first >> https://lore.kernel.org/patchwork/project/lkml/list/?series=487403 >> >> arch/arm64/boot/dts/qcom/pm7325.dtsi | 60 ++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 60 ++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/pmk8350.dtsi | 104 >> ++++++++++++++++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/pmr735a.dtsi | 60 ++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 +++ >> 5 files changed, 292 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi >> create mode 100644 arch/arm64/boot/dts/qcom/pm8350c.dtsi >> create mode 100644 arch/arm64/boot/dts/qcom/pmk8350.dtsi >> create mode 100644 arch/arm64/boot/dts/qcom/pmr735a.dtsi >> >> diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi >> b/arch/arm64/boot/dts/qcom/pm7325.dtsi >> new file mode 100644 >> index 0000000..393b256 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi >> @@ -0,0 +1,60 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +// Copyright (c) 2021, The Linux Foundation. All rights reserved. >> + >> +#include >> +#include >> + >> +&spmi_bus { >> + pm7325: pmic@1 { >> + compatible = "qcom,pm7325", "qcom,spmi-pmic"; >> + reg = <0x1 SPMI_USID>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + pm7325_tz: temp-alarm@a00 { >> + compatible = "qcom,spmi-temp-alarm"; >> + reg = <0xa00>; >> + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; >> + #thermal-sensor-cells = <0>; >> + }; >> + >> + pm7325_gpios: gpios@8800 { >> + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio"; >> + reg = <0x8800>; >> + gpio-controller; >> + gpio-ranges = <&pm7325_gpios 0 0 10>; >> + #gpio-cells = <2>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + }; >> + }; >> +}; >> + >> +&thermal_zones { >> + pm7325_temp_alarm: pm7325_tz { > > '_' is not allowed to be used in node names, there's a few of these > sprinkled through the patch. Please replace them with '-'. > Okay, will replace them. >> + polling-delay-passive = <100>; >> + polling-delay = <0>; >> + thermal-governor = "step_wise"; >> + thermal-sensors = <&pm7325_tz>; >> + >> + trips { >> + pm7325_trip0: trip0 { >> + temperature = <95000>; >> + hysteresis = <0>; >> + type = "passive"; >> + }; >> + >> + pm7325_trip1: trip1 { >> + temperature = <115000>; >> + hysteresis = <0>; >> + type = "critical"; >> + }; >> + >> + pm7325_trip2: trip2 { >> + temperature = <145000>; >> + hysteresis = <0>; >> + type = "critical"; >> + }; >> + }; >> + }; >> +}; > [..] >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> index 8af6d77..25402d4 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> @@ -606,4 +606,12 @@ >> , >> ; >> }; >> + >> + thermal_zones: thermal-zones { >> + }; >> }; >> + >> +#include "pm7325.dtsi" >> +#include "pm8350c.dtsi" >> +#include "pmk8350.dtsi" >> +#include "pmr735a.dtsi" > > Is there any particular reason for you including these at the end of > sc7270.dtsi, rather than the top like we do in other platforms? > > Also, are all SC7280 devices always coming with this quartet? We've > seen > variations of this in the past and therefor typically include them from > the board dts instead. > No specific reason, will add them in board dts file. > Regards, > Bjorn Thanks, Satya Priya