From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D3FEB64DD for ; Mon, 3 Jul 2023 13:12:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230332AbjGCNMO (ORCPT ); Mon, 3 Jul 2023 09:12:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231309AbjGCNMN (ORCPT ); Mon, 3 Jul 2023 09:12:13 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE914E41 for ; Mon, 3 Jul 2023 06:12:11 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3141140f51bso5957685f8f.1 for ; Mon, 03 Jul 2023 06:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688389930; x=1690981930; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3C72+69VGn6Vh4PEX3kulCzL7RyUsSJTOHMj9jDZHN8=; b=uKaA9p0Ox2ovUpVrrVYgiLiawXF/eJHtDmw08cPCzgZCbB60Ie8INNvKUxBIAKmL3Y gJjymwQdcF7raXNSF8V6wRpvvBFTtLf7turtg9TU69p5lKeXMaD3Z6AKI9UYiwJRApAI IwHg9pDdFL6ENpVemuwnYsQ1q7YBVDw7d2I64puqIHBLNSMNvR3bY+KieueemlUZI4Wx VNwKAbld7p6chbwhedWQ/HFD3cmZG4DjjGBZ1UDZ5JQMWdmeF/kgXYKIpM3ZHIQHpGNk JalLPDuZ1BM6md6B3Gsm+P5SO/aD6zQVkMFh25wH0/768JWkKOd5sOlYeVUH5tPTISd3 ABLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688389930; x=1690981930; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3C72+69VGn6Vh4PEX3kulCzL7RyUsSJTOHMj9jDZHN8=; b=XglmvUYFGhs4Yhk9AmCZjvdXQLvArZtol24TBEliv8XAb9whDwGZHzkbim3lToNe7i 2M5Zc2wEeuPVb8O3pIAUKymSiY0iqDaYtqevd34vynEc5AvKF1DSB+BGyx9jWlNWe8VF ujy6cq+5kUtuKjHNPMdJcyyMch2Wdl6R6hm0M6xsWKMLGfOgbW2OT0aRMmpYqYV5Gliz x2hWq41kKoUBBLO9VL3G/5gPdRywhDtKwkQlbF6ivVaH8WL5e/e9X1gjRCJs4cinfWRv /TRvERHQ66GQNHr5yt+X+UkCfIeDr9yhP7lGMT7L8u9guMxYm6NMQZG6FbGrkVOyzqrj 2a/w== X-Gm-Message-State: ABy/qLY3efZjl9BFwquZiUA+3t22CK3G8dL92Hz0hY36OH6Gvb3c1u4z eJiTqkVcb6hCI/QOfZcjhf1ZLQ== X-Google-Smtp-Source: APBJJlGzI2y08jEzmUxZusXD3XCrTA4WMsvMiPknAxeFAukczBsa/LAjJj2fSLhRTg7ATBgccqwsAQ== X-Received: by 2002:adf:ee51:0:b0:313:fd52:af37 with SMTP id w17-20020adfee51000000b00313fd52af37mr10499400wro.4.1688389930317; Mon, 03 Jul 2023 06:12:10 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id m16-20020a5d6250000000b003068f5cca8csm25443464wrv.94.2023.07.03.06.12.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 06:12:09 -0700 (PDT) Message-ID: Date: Mon, 3 Jul 2023 15:12:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/3] dt-bindings: power: add Amlogic C3 power domains To: =Xianwei Zhao , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman References: <20230703093142.2028500-1-xianwei.zhao@amlogic.com> <20230703093142.2028500-2-xianwei.zhao@amlogic.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230703093142.2028500-2-xianwei.zhao@amlogic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/07/2023 11:31, =Xianwei Zhao wrote: > From: Xianwei Zhao > > Add devicetree binding document and related header file for Amlogic C3 secure power domains. > > Signed-off-by: Xianwei Zhao > --- > .../power/amlogic,meson-sec-pwrc.yaml | 3 ++- > include/dt-bindings/power/amlogic-c3-power.h | 26 +++++++++++++++++++ > 2 files changed, 28 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/power/amlogic-c3-power.h > > diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml > index eab21bb2050a..d80bbedfe3aa 100644 > --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml > +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml > @@ -12,7 +12,7 @@ maintainers: > - Jianxin Pan > > description: |+ > - Secure Power Domains used in Meson A1/C1/S4 SoCs, and should be the child node > + Secure Power Domains used in Meson A1/C1/S4 & C3 SoCs, and should be the child node > of secure-monitor. > > properties: > @@ -20,6 +20,7 @@ properties: > enum: > - amlogic,meson-a1-pwrc > - amlogic,meson-s4-pwrc > + - amlogic,c3-pwrc > > "#power-domain-cells": > const: 1 > diff --git a/include/dt-bindings/power/amlogic-c3-power.h b/include/dt-bindings/power/amlogic-c3-power.h > new file mode 100644 > index 000000000000..3403e7c0b49d > --- /dev/null > +++ b/include/dt-bindings/power/amlogic-c3-power.h Filename matching compatibles, please. > @@ -0,0 +1,26 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */ > +/* > + * Copyright (c) 2023 Amlogic, Inc. > + * Author: hongyu chen1 > + */ > +#ifndef _DT_BINDINGS_AMLOGIC_C3_POWER_H > +#define _DT_BINDINGS_AMLOGIC_C3_POWER_H > + > +#define PWRC_C3_NNA_ID 0 > +#define PWRC_C3_AUDIO_ID 1 > +#define PWRC_C3_RESV_SEC_ID 2 > +#define PWRC_C3_SDIOA_ID 3 > +#define PWRC_C3_EMMC_ID 4 > +#define PWRC_C3_USB_COMB_ID 5 > +#define PWRC_C3_SDCARD_ID 6 > +#define PWRC_C3_ETH_ID 7 > +#define PWRC_C3_RESV0_ID 8 > +#define PWRC_C3_GE2D_ID 9 > +#define PWRC_C3_CVE_ID 10 > +#define PWRC_C3_GDC_WRAP_ID 11 > +#define PWRC_C3_ISP_TOP_ID 12 > +#define PWRC_C3_MIPI_ISP_WRAP_ID 13 > +#define PWRC_C3_VCODEC_ID 14 > + > +#endif > + No need for stray blank line. Best regards, Krzysztof