From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Binbin Zhou <zhoubb.aaron@gmail.com>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, Huacai Chen <chenhuacai@kernel.org>,
loongson-kernel@lists.loongnix.cn,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, Yingkun Meng <mengyingkun@loongson.cn>,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH RESEND v2 1/2] dt-bindings: dmaengine: Add Loongson LS2X APB DMA controller
Date: Sat, 10 Jun 2023 11:26:54 +0200 [thread overview]
Message-ID: <d1d04801-beed-c694-b6bb-0c0aa86ea014@linaro.org> (raw)
In-Reply-To: <CAMpQs4JF-HtHpb_3YJBUNo2x6_E=S-gf1p9kJ7vp01S62PYSxw@mail.gmail.com>
On 10/06/2023 07:35, Binbin Zhou wrote:
> On Sat, Jun 10, 2023 at 12:49 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 08/06/2023 04:55, Binbin Zhou wrote:
>>> Add Loongson LS2X APB DMA controller binding with DT schema
>>> format using json-schema.
>>>
>>> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
>>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>>
>>
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - const: loongson,ls2k1000-apbdma
>>> + - items:
>>> + - const: loongson,ls2k0500-apbdma
>>> + - const: loongson,ls2k1000-apbdma
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + "#dma-cells":
>>> + const: 1
>>> +
>>> + dma-channels:
>>> + const: 1
>>
>> If it is const, why do you need it?
>>
> Hi Krzysztof:
>
> IMO, although it is a single-channel DMAC, the "dma-channels" are
> still needed for a more comprehensive description of the hardware.
How does it describe more the hardware if it is obvious and always the
same? If so, why you didn't add properties like reg-io-width,
dma-requests, clock-frequency, clocks (BTW, this actually is missing),
dma-channel-mask and hundreds of others?
No, drop, it does not make sense.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-10 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 2:51 [PATCH v2 0/2] New driver for the Loongson LS2X APB DMA Controller Binbin Zhou
2023-06-08 2:51 ` [PATCH v2 1/2] dt-bindings: dmaengine: Add Loongson LS2X APB DMA controller Binbin Zhou
2023-06-08 2:55 ` [PATCH RESEND " Binbin Zhou
2023-06-09 16:48 ` Krzysztof Kozlowski
2023-06-10 5:35 ` Binbin Zhou
2023-06-10 9:26 ` Krzysztof Kozlowski [this message]
2023-06-08 2:51 ` [PATCH v2 2/2] dmaengine: ls2x-apb: new driver for the " Binbin Zhou
2023-06-08 2:55 ` [PATCH RESEND " Binbin Zhou
2023-06-08 2:55 ` [PATCH RESEND v2 0/2] New driver for the Loongson LS2X APB DMA Controller Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1d04801-beed-c694-b6bb-0c0aa86ea014@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=mengyingkun@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).