From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00FFBC77B7A for ; Sat, 10 Jun 2023 09:27:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234219AbjFJJ1A (ORCPT ); Sat, 10 Jun 2023 05:27:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231949AbjFJJ1A (ORCPT ); Sat, 10 Jun 2023 05:27:00 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B043AA8 for ; Sat, 10 Jun 2023 02:26:58 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-977d55ac17bso466631766b.3 for ; Sat, 10 Jun 2023 02:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686389217; x=1688981217; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iW0IFdJ2visMWM7LxTWXXt4WCl5RIYV8ZLooUjiB3F8=; b=Lk8sSDMO07OVN4bc95Zfj8fyn4zhfBlk7q/8qXgmoaEc4PE2PxACmSJw47YIRH+Irq Dy5Ja8Yhu3DTX5DLmIYwo0CwS3QJFmRs63/6aZy6pq2a5cv6d9XepSIW/+/ugfEmqJN+ B7vVe8Jo9Xc6PMPFw/aK6k3e9k2/NPuGKMbSJkNxyvVJbAEwLtUMHItcBQTITHbx1owf jxTZ1UUs6M+nIGkembMkkA7YPWkzGJr6dcSQm7xQPo9KUwaaNrNsygQNaBlVssivgZXy Hch+LJzSHqZ3a/OOYhStzKCjzoqO4uXQP/4fFeAM5Ni427z1s3N7MPAb6jjoTFeeH+f6 dfoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686389217; x=1688981217; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iW0IFdJ2visMWM7LxTWXXt4WCl5RIYV8ZLooUjiB3F8=; b=PniIX5UOSGs556js8IBVuAa7527TOJKcYmv/PG6IDzDD/d5AWxyUGAdzc5XlSfhLWl KNK+xkNUXuU/YG07VJyR7mk1+9bDYKJMX0s0Y8HWTDSs2lY2naJV4Z6QL64pRELwO5pG OsAJoBV0aPT4dmHMP/CiJIhrrsevXIAZOCTgLUIaU4A6TKMr9Rw/kBt4oRpJ+mF4JxJu 5g/8Fs8b7XtViAoFtCibOKzzN+VZDqKt56H0sgZQrEmdndCtI60l6PtztZmK4Ua6456O PcLaKT2BZJ0y/v4ltw7JIPOT7wa5+88HPL4l0fQBe3GIrLdMg51WPPeaxHesejt7fy2Y F5mg== X-Gm-Message-State: AC+VfDxHCmpWs4lJePkm5lM/aBKlD0yY6zPqSZGQUSuoFiwowsx7OLaK m4EV0Z1aVgeJmmH02hlBKmF2lw== X-Google-Smtp-Source: ACHHUZ6I2N1VhbYFzh7avlcgvmLESziO91Lcx5Mq2YqOB7W/6BZ3VUlE95Mgm8ZF4JvM3Amn7Kb+Hw== X-Received: by 2002:a17:907:8a12:b0:970:1bc9:2eeb with SMTP id sc18-20020a1709078a1200b009701bc92eebmr5423427ejc.30.1686389217251; Sat, 10 Jun 2023 02:26:57 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id g13-20020a056402114d00b0051830f22825sm199320edw.90.2023.06.10.02.26.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Jun 2023 02:26:56 -0700 (PDT) Message-ID: Date: Sat, 10 Jun 2023 11:26:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH RESEND v2 1/2] dt-bindings: dmaengine: Add Loongson LS2X APB DMA controller Content-Language: en-US To: Binbin Zhou Cc: Binbin Zhou , Huacai Chen , Vinod Koul , dmaengine@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, Huacai Chen , loongson-kernel@lists.loongnix.cn, Xuerui Wang , loongarch@lists.linux.dev, Yingkun Meng , Conor Dooley References: <68bb3816-d707-3a21-59a2-8785dce7210a@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/06/2023 07:35, Binbin Zhou wrote: > On Sat, Jun 10, 2023 at 12:49 AM Krzysztof Kozlowski > wrote: >> >> On 08/06/2023 04:55, Binbin Zhou wrote: >>> Add Loongson LS2X APB DMA controller binding with DT schema >>> format using json-schema. >>> >>> Signed-off-by: Binbin Zhou >>> Reviewed-by: Conor Dooley >> >> >>> +properties: >>> + compatible: >>> + oneOf: >>> + - const: loongson,ls2k1000-apbdma >>> + - items: >>> + - const: loongson,ls2k0500-apbdma >>> + - const: loongson,ls2k1000-apbdma >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> + "#dma-cells": >>> + const: 1 >>> + >>> + dma-channels: >>> + const: 1 >> >> If it is const, why do you need it? >> > Hi Krzysztof: > > IMO, although it is a single-channel DMAC, the "dma-channels" are > still needed for a more comprehensive description of the hardware. How does it describe more the hardware if it is obvious and always the same? If so, why you didn't add properties like reg-io-width, dma-requests, clock-frequency, clocks (BTW, this actually is missing), dma-channel-mask and hundreds of others? No, drop, it does not make sense. Best regards, Krzysztof