From: Michal Simek <michal.simek@xilinx.com>
To: Moritz Fischer <moritz.fischer@ettus.com>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Michal Simek" <michal.simek@xilinx.com>,
"U-Boot List" <u-boot@lists.denx.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Moritz Fischer" <mdf@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>
Subject: Re: [PATCH] ARM64: zynqmp: Fix i2c node's compatible string
Date: Thu, 22 Dec 2016 08:35:19 +0100 [thread overview]
Message-ID: <d1e69302-8367-7c57-ecd7-f72861c3a49e@xilinx.com> (raw)
In-Reply-To: <1482385788-7187-1-git-send-email-moritz.fischer@ettus.com>
On 22.12.2016 06:49, Moritz Fischer wrote:
> From: Moritz Fischer <mdf@kernel.org>
>
> The Zynq Ultrascale MP uses version 1.4 of the Cadence IP core
> which fixes some silicon bugs that needed software workarounds
> in Version 1.0 that was used on Zynq systems.
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
> Cc: U-Boot List <u-boot@lists.denx.de>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
>
> Hi Michal,
>
> I think this is a slip up and should be r1p14 for
> Ultrascale ZynqMP. drivers/i2c/i2c-cadence.c already uses this.
> I Cc'd the u-boot list, because the same change would be required there.
>
> Cheers,
>
> Moritz
>
> ---
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 68a90833..a5a5f91 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -175,7 +175,7 @@
> };
>
> i2c0: i2c@ff020000 {
> - compatible = "cdns,i2c-r1p10";
> + compatible = "cdns,i2c-r1p14";
I was checking this internally and p10 is doing something what p14
doesn't need to do. That's why this should be
compatible = "cdns,i2c-r1p14", "cdns,i2c-r1p10";
The same of course for u-boot where also p14 should be added to the driver.
Thanks,
Michal
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
next prev parent reply other threads:[~2016-12-22 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 5:49 [PATCH] ARM64: zynqmp: Fix i2c node's compatible string Moritz Fischer
2016-12-22 7:35 ` Michal Simek [this message]
[not found] ` <d1e69302-8367-7c57-ecd7-f72861c3a49e-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2016-12-22 16:26 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1e69302-8367-7c57-ecd7-f72861c3a49e@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).