From: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh+dt@kernel.org>, <alsa-devel@alsa-project.org>,
<patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 4/7] ASoC: cs35l45: Analog PCM Volume and Amplifier Mode controls
Date: Wed, 30 Aug 2023 10:55:51 -0500 [thread overview]
Message-ID: <d1ed5bf6-24e7-53d7-512b-ceab9e0a7e3d@opensource.cirrus.com> (raw)
In-Reply-To: <ZOz35ABAsLYROJ4c@finisterre.sirena.org.uk>
On 8/28/23 14:39, Mark Brown wrote:
> On Mon, Aug 28, 2023 at 12:05:22PM -0500, Vlad Karpovich wrote:
>
>> +static int cs35l45_amplifier_mode_put(struct snd_kcontrol *kcontrol,
>> + struct snd_ctl_elem_value *ucontrol)
>> +{
>> + snd_soc_component_enable_pin_unlocked(component, "SPK");
>> + snd_soc_dapm_sync_unlocked(dapm);
>> + snd_soc_dapm_mutex_unlock(dapm);
>> + cs35l45->amplifier_mode = ucontrol->value.integer.value[0];
>> + return 0;
>> +}
> This should return 1 on change (I did see that there's some code which
> generates notifications but it would still be better to flag changes
> here, it makes review a lot easier).
Thanks. I will update patch.
next prev parent reply other threads:[~2023-08-30 18:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 17:05 [PATCH 1/7] ASoC: cs35l45: Add support for Chip ID 0x35A460 Vlad Karpovich
2023-08-28 17:05 ` [PATCH 2/7] ASoC: cs35l45: Fix "Dead assigment" warning Vlad Karpovich
2023-08-29 10:04 ` Charles Keepax
2023-08-28 17:05 ` [PATCH 3/7] ASoC: cs35l45: Checks index of cs35l45_irqs[] Vlad Karpovich
2023-08-29 10:07 ` Charles Keepax
2023-08-29 18:17 ` Vlad Karpovich
2023-08-28 17:05 ` [PATCH 4/7] ASoC: cs35l45: Analog PCM Volume and Amplifier Mode controls Vlad Karpovich
2023-08-28 19:39 ` Mark Brown
2023-08-30 15:55 ` Vlad Karpovich [this message]
2023-08-28 17:05 ` [PATCH 5/7] ASoC: cs35l45: Rename DACPCM1 Source control Vlad Karpovich
2023-08-29 10:08 ` Charles Keepax
2023-08-28 17:05 ` [PATCH 6/7] ASoC: cs35l45: Connect DSP to the monitoring signals Vlad Karpovich
2023-08-29 10:11 ` Charles Keepax
2023-08-28 17:05 ` [PATCH 7/7] ASoC: cs35l45: Add AMP Enable Switch control Vlad Karpovich
2023-08-29 10:13 ` Charles Keepax
2023-08-29 10:04 ` [PATCH 1/7] ASoC: cs35l45: Add support for Chip ID 0x35A460 Charles Keepax
2023-08-29 19:12 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1ed5bf6-24e7-53d7-512b-ceab9e0a7e3d@opensource.cirrus.com \
--to=vkarpovi@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=james.schulman@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).