From: Matthias Brugger <matthias.bgg@gmail.com>
To: Weiyi Lu <weiyi.lu@mediatek.com>, Rob Herring <robh@kernel.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@baylibre.com>,
James Liao <jamesjj.liao@mediatek.com>,
Fan Chen <fan.chen@mediatek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-clk@vger.kernel.org, srv_heupstream@mediatek.com
Subject: Re: [PATCH v1 3/5] dt-bindings: clock: add clocks for MT2712
Date: Sun, 11 Mar 2018 23:27:41 +0100 [thread overview]
Message-ID: <d1f7b0e7-fa9b-cc87-80df-3479db8b9281@gmail.com> (raw)
In-Reply-To: <1519957404.14513.5.camel@mtksdaap41>
On 03/02/2018 03:23 AM, Weiyi Lu wrote:
> On Thu, 2018-03-01 at 16:45 -0600, Rob Herring wrote:
>> On Thu, Feb 22, 2018 at 01:48:49PM +0800, Weiyi Lu wrote:
>>> add new clocks according to ECO design change
>>>
>>> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
>>> ---
>>> include/dt-bindings/clock/mt2712-clk.h | 294 +++++++++++++++++----------------
>>> 1 file changed, 151 insertions(+), 143 deletions(-)
>>
>> You can't just renumber your clocks. They are an ABI. Plus, for an ECO
>> there can't have been that much change.
>>
> Hi Rob,
> Got it! Is it correct if I append those new added clocks at the bottom
> of each own subsystem? If the answer is yes, I'll resend a new version.
Yes, that will work. Please do that and resubmit.
Thanks,
Matthias
next prev parent reply other threads:[~2018-03-11 22:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 5:48 [PATCH v1 0/5] update Mediatek MT2712 clock and scpsys support Weiyi Lu
[not found] ` <20180222054851.26096-1-weiyi.lu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-02-22 5:48 ` Weiyi Lu
2018-02-22 5:48 ` [PATCH v1 1/5] dt-bindings: soc: update MT2712 power dt-bindings Weiyi Lu
2018-03-01 22:41 ` Rob Herring
2018-02-22 5:48 ` [PATCH v1 2/5] soc: mediatek: update power domain data of MT2712 Weiyi Lu
2018-02-22 5:48 ` [PATCH v1 3/5] dt-bindings: clock: add clocks for MT2712 Weiyi Lu
2018-03-01 22:45 ` Rob Herring
2018-03-02 2:23 ` Weiyi Lu
2018-03-11 22:27 ` Matthias Brugger [this message]
2018-02-22 5:48 ` [PATCH v1 4/5] arm64: dts: add clock device nodes of MT2712 Weiyi Lu
2018-02-22 5:48 ` [PATCH v1 5/5] clk: mediatek: update clock driver " Weiyi Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1f7b0e7-fa9b-cc87-80df-3479db8b9281@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fan.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srv_heupstream@mediatek.com \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).