From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: shruthi.sanil@intel.com, tglx@linutronix.de, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
mgross@linux.intel.com, srikanth.thokala@intel.com,
lakshmi.bai.raja.subramanian@intel.com,
mallikarjunappa.sangannavar@intel.com
Subject: Re: [PATCH v8 2/2] clocksource: Add Intel Keem Bay timer support
Date: Wed, 2 Mar 2022 16:58:08 +0100 [thread overview]
Message-ID: <d1f82398-3f94-2f48-db92-d1fe487032c7@linaro.org> (raw)
In-Reply-To: <Yh925VvqejDe2SR8@smile.fi.intel.com>
On 02/03/2022 14:53, Andy Shevchenko wrote:
> On Tue, Mar 01, 2022 at 10:09:06PM +0100, Daniel Lezcano wrote:
>> On 22/02/2022 10:56, shruthi.sanil@intel.com wrote:
>
>>> + /* Clear interrupt for periodic timer*/
>>
>> nit: comment format is:
>>
>> /*
>> * my comment
>> */
>>
>> One line comment format is usually for the network subsystem
>
> Huh?
> Any pointers to the documentation, please?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst#n598
Well actually it is for multi line, so I may have confused with these
one line comments.
On the other hand having one line comment telling what does the function
right after is not really useful. The function names are self-explanatory.
>>> + keembay_timer_clear_pending_int(tim_base);
>>> + } else {
>>> + /* Disable the timer for one shot timer */
>>
>> comment format
>>
>>> + keembay_timer_disable(tim_base);
>>> + }
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2022-03-02 15:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 9:56 [PATCH v8 0/2] Add the driver for Intel Keem Bay SoC timer block shruthi.sanil
2022-02-22 9:56 ` [PATCH v8 1/2] dt-bindings: timer: Add bindings for Intel Keem Bay SoC Timer shruthi.sanil
2022-02-22 23:13 ` Rob Herring
2022-02-23 7:49 ` Sanil, Shruthi
2022-02-23 11:30 ` Andy Shevchenko
2022-03-07 22:33 ` Rob Herring
2022-03-08 10:13 ` Andy Shevchenko
2022-03-18 5:36 ` Sanil, Shruthi
2022-06-06 17:47 ` Sanil, Shruthi
2022-06-16 3:42 ` Sanil, Shruthi
2022-02-22 9:56 ` [PATCH v8 2/2] clocksource: Add Intel Keem Bay timer support shruthi.sanil
2022-02-28 7:39 ` Sanil, Shruthi
2022-03-01 21:09 ` Daniel Lezcano
2022-03-02 10:12 ` Sanil, Shruthi
2022-03-02 10:24 ` Daniel Lezcano
2022-03-02 16:07 ` Sanil, Shruthi
2022-03-02 16:26 ` Daniel Lezcano
2022-03-03 6:18 ` Sanil, Shruthi
2022-03-03 10:17 ` Daniel Lezcano
2022-03-03 10:23 ` Sanil, Shruthi
2022-03-03 10:48 ` andriy.shevchenko
2022-03-03 10:51 ` Sanil, Shruthi
2022-03-03 10:47 ` andriy.shevchenko
2022-03-03 13:04 ` Daniel Lezcano
2022-03-02 13:54 ` andriy.shevchenko
2022-03-02 13:53 ` Andy Shevchenko
2022-03-02 15:58 ` Daniel Lezcano [this message]
2022-03-02 16:07 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1f82398-3f94-2f48-db92-d1fe487032c7@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mgross@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shruthi.sanil@intel.com \
--cc=srikanth.thokala@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).