From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E235C433F5 for ; Wed, 2 Mar 2022 15:58:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235578AbiCBP7A (ORCPT ); Wed, 2 Mar 2022 10:59:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233380AbiCBP67 (ORCPT ); Wed, 2 Mar 2022 10:58:59 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5406E49935 for ; Wed, 2 Mar 2022 07:58:16 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id p184-20020a1c29c1000000b0037f76d8b484so1519426wmp.5 for ; Wed, 02 Mar 2022 07:58:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=S7tBxL3zCrsmorspR7qPusrnc1TbsRYLggUh4+p6MEo=; b=x7f7c2SCinYE0MhyzXnrqP7gjrhNRCE4IyOZQSela0bBvemhD+IbNSM+fPbXcMa8Rz RUAvlekxqc9fQEFuKlfqxAVxZekoNANTDkXI1SdGwjelE03LqmuSltivVZmw0Ep5hSWs ztLpCVRSCE7uQnRGcD0GV/9CC+bfmRpWqG/FuSf8qQn7IC0A2fzeehWs4lSWICvnf7iV OFwl4xO0qAlqi+6VgrfyLEQbq1uscBTk0XYElKcO3NVKUstvQ1lZh++f84FUr0OLMm3S ZxtCLYA16yDxYWvv4N80WLNnhtm6lNgGx7e8gv6Yz6sN470Eg0A8baKKgJM7zzwpzccA 8YTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=S7tBxL3zCrsmorspR7qPusrnc1TbsRYLggUh4+p6MEo=; b=Y1BncgnpwaN0ANYL6mFqH/dgCOuRgb5BWSRt6E0DEefo6UTtJB7psSGVbxMtgC3N7b Npd0DnVscodkEt5zAlchRGUsFxN192j2nsWq0cXJ9dCU8uo/ByOwah7Mlwh245kpIWrf raXGXiMaSx82W+/xZGtnQxB/YEtOzh3obf1hOB1tX3F5ZKEOoJOz8a0rMqj9kIAONn+n cPzR76m2kZDNN0+GqfBWBlGVGGBKMKpTnI3ZAzoZ9te+FIr6WpsUVpXSmVzMI7Jfcddf sepbLB5vQw4C1Klae320vr2IWRvDlXmwpxYtAt/2ZtGExJU8HORia77v9Lc94WqLgbcl Wa8g== X-Gm-Message-State: AOAM531lT6bpIeFBoEIgrEqmw/M9ZuFXfR+nETP2UxOvJU7/uvIdG5oS HUuQgTpZsW2lVc0gXYDR5dqtmA== X-Google-Smtp-Source: ABdhPJypg+b21zNLXqV+F0y7KcTaJmTZ+m1NyDelT51EGx+VrpgB4V48jUYw7ZH84y1/mFvFnaqTWQ== X-Received: by 2002:a05:600c:1c9c:b0:386:f4ed:3f59 with SMTP id k28-20020a05600c1c9c00b00386f4ed3f59mr189896wms.27.1646236694737; Wed, 02 Mar 2022 07:58:14 -0800 (PST) Received: from ?IPV6:2a01:e34:ed2f:f020:b9e3:8853:bc0:bb98? ([2a01:e34:ed2f:f020:b9e3:8853:bc0:bb98]) by smtp.googlemail.com with ESMTPSA id l7-20020adfc787000000b001f049375350sm487067wrg.8.2022.03.02.07.58.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Mar 2022 07:58:13 -0800 (PST) Message-ID: Date: Wed, 2 Mar 2022 16:58:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v8 2/2] clocksource: Add Intel Keem Bay timer support Content-Language: en-US To: Andy Shevchenko Cc: shruthi.sanil@intel.com, tglx@linutronix.de, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, mgross@linux.intel.com, srikanth.thokala@intel.com, lakshmi.bai.raja.subramanian@intel.com, mallikarjunappa.sangannavar@intel.com References: <20220222095654.9097-1-shruthi.sanil@intel.com> <20220222095654.9097-3-shruthi.sanil@intel.com> <91653d8d-1dc6-0170-2c3c-1187b0bad899@linaro.org> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/03/2022 14:53, Andy Shevchenko wrote: > On Tue, Mar 01, 2022 at 10:09:06PM +0100, Daniel Lezcano wrote: >> On 22/02/2022 10:56, shruthi.sanil@intel.com wrote: > >>> + /* Clear interrupt for periodic timer*/ >> >> nit: comment format is: >> >> /* >> * my comment >> */ >> >> One line comment format is usually for the network subsystem > > Huh? > Any pointers to the documentation, please? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst#n598 Well actually it is for multi line, so I may have confused with these one line comments. On the other hand having one line comment telling what does the function right after is not really useful. The function names are self-explanatory. >>> + keembay_timer_clear_pending_int(tim_base); >>> + } else { >>> + /* Disable the timer for one shot timer */ >> >> comment format >> >>> + keembay_timer_disable(tim_base); >>> + } > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog