From: Philipp Zabel <p.zabel@pengutronix.de>
To: Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Dilip Kota <eswara.kota@linux.intel.com>
Subject: Re: [PATCH] dt-bindings: reset: intel,rcu-gw: Fix intel,global-reset schema
Date: Tue, 14 Jan 2020 11:08:57 +0100 [thread overview]
Message-ID: <d1f969346ad1758943e8f898244c69673f93f129.camel@pengutronix.de> (raw)
In-Reply-To: <20200113214515.3950-1-robh@kernel.org>
Hi Rob,
On Mon, 2020-01-13 at 15:45 -0600, Rob Herring wrote:
> The intel,rcu-gw binding example has an error:
>
> Documentation/devicetree/bindings/reset/intel,rcu-gw.example.dt.yaml:
> reset-controller@e0000000: intel,global-reset: [[16, 30]] is too short
>
> The error isn't really correct as the problem is in how the data is
> encoded and the schema is not fixed up by the tooling correctly.
> However, array properties should describe the elements in the array, so
> lets do that which fixes the error in the process.
>
> Fixes: b7ab0cb00d08 ("dt-bindings: reset: Add YAML schemas for the Intel Reset controller")
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Dilip Kota <eswara.kota@linux.intel.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml
> index 246dea8a2ec9..8ac437282659 100644
> --- a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml
> +++ b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml
> @@ -23,7 +23,11 @@ properties:
> description: Global reset register offset and bit offset.
> allOf:
> - $ref: /schemas/types.yaml#/definitions/uint32-array
> - - maxItems: 2
> + items:
> + - description: Register offset
> + - description: Register bit offset
> + minimum: 0
> + maximum: 31
>
> "#reset-cells":
> minimum: 2
Thank you, applied to reset/next.
regards
Philipp
prev parent reply other threads:[~2020-01-14 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 21:45 [PATCH] dt-bindings: reset: intel,rcu-gw: Fix intel,global-reset schema Rob Herring
2020-01-14 9:54 ` Dilip Kota
2020-01-14 10:03 ` Dilip Kota
2020-01-14 10:08 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1f969346ad1758943e8f898244c69673f93f129.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=eswara.kota@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).