From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E1EC33CB1 for ; Tue, 14 Jan 2020 10:09:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 831962467A for ; Tue, 14 Jan 2020 10:09:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730763AbgANKI7 (ORCPT ); Tue, 14 Jan 2020 05:08:59 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:58487 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731178AbgANKI6 (ORCPT ); Tue, 14 Jan 2020 05:08:58 -0500 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1irJ85-00031o-H6; Tue, 14 Jan 2020 11:08:57 +0100 Message-ID: Subject: Re: [PATCH] dt-bindings: reset: intel,rcu-gw: Fix intel,global-reset schema From: Philipp Zabel To: Rob Herring , devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Dilip Kota Date: Tue, 14 Jan 2020 11:08:57 +0100 In-Reply-To: <20200113214515.3950-1-robh@kernel.org> References: <20200113214515.3950-1-robh@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On Mon, 2020-01-13 at 15:45 -0600, Rob Herring wrote: > The intel,rcu-gw binding example has an error: > > Documentation/devicetree/bindings/reset/intel,rcu-gw.example.dt.yaml: > reset-controller@e0000000: intel,global-reset: [[16, 30]] is too short > > The error isn't really correct as the problem is in how the data is > encoded and the schema is not fixed up by the tooling correctly. > However, array properties should describe the elements in the array, so > lets do that which fixes the error in the process. > > Fixes: b7ab0cb00d08 ("dt-bindings: reset: Add YAML schemas for the Intel Reset controller") > Cc: Philipp Zabel > Cc: Dilip Kota > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml > index 246dea8a2ec9..8ac437282659 100644 > --- a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml > +++ b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml > @@ -23,7 +23,11 @@ properties: > description: Global reset register offset and bit offset. > allOf: > - $ref: /schemas/types.yaml#/definitions/uint32-array > - - maxItems: 2 > + items: > + - description: Register offset > + - description: Register bit offset > + minimum: 0 > + maximum: 31 > > "#reset-cells": > minimum: 2 Thank you, applied to reset/next. regards Philipp