Re: [PATCH 3/3] arm64: dts: rockchip: Add OneThing Edge Cube series

["Dragan Simic" <dsimic@manjaro.org>]

Hello Jun,

Please, see a quick remark below, for now.

On Saturday, January 31, 2026 16:31 CET, Jun Yan <jerrysteve1101@gmail.com> wrote:
> The OneThing Edge Cube (OEC) series features the RK3566 SoC, 8GB
> eMMC storage, and supports one SATA interface, one Gigabit Ethernet
> port, and one USB 3.0 port.
> 
> Other than the difference in RAM capacity, the OEC and OEC-turbo are
> identical in all other specifications.
> 
>   Specification:
>     - Rockchip RK3566
>     - LPDDR4X 2GB (OEC) / 4GB (OEC-turbo)
>     - eMMC 8GB
>     - Gigabit Ethernet port x 1
>     - USB 3.0 port x 1
>     - USB-C 2.0 port x 1
>     - 12V DC Power supply
>     - SATA 3.0 connector x 1
> 
> Signed-off-by: Jun Yan <jerrysteve1101@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   2 +
>  .../rockchip/rk3566-onething-oec-turbo.dts    |  10 +
>  .../boot/dts/rockchip/rk3566-onething-oec.dts |  10 +
>  .../dts/rockchip/rk3566-onething-oec.dtsi     | 309 ++++++++++++++++++
>  4 files changed, 331 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-onething-oec-turbo.dts
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-onething-oec.dts
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-onething-oec.dtsi
> 
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 4d384f153c13..ec57719e4573 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -104,6 +104,8 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg353v.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg353vs.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg503.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-odroid-m1s.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-onething-oec.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-onething-oec-turbo.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-orangepi-3b-v1.1.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-orangepi-3b-v2.1.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.1.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-onething-oec-turbo.dts b/arch/arm64/boot/dts/rockchip/rk3566-onething-oec-turbo.dts
> new file mode 100644
> index 000000000000..16d0cd0cf577
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-onething-oec-turbo.dts
> @@ -0,0 +1,10 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include "rk3566-onething-oec.dtsi"
> +
> +/ {
> +	model = "OneThing OEC-turbo";
> +	compatible = "onething,oec-turbo", "rockchip,rk3566";
> +};
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-onething-oec.dts b/arch/arm64/boot/dts/rockchip/rk3566-onething-oec.dts
> new file mode 100644
> index 000000000000..81da771ad63d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-onething-oec.dts
> @@ -0,0 +1,10 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include "rk3566-onething-oec.dtsi"
> +
> +/ {
> +	model = "OneThing OEC";
> +	compatible = "onething,oec", "rockchip,rk3566";
> +};

The only difference between the two OneThing OEC board variants is, as
far as I can tell, the amount of LPDDR4X DRAM they have, so I don't think
it's justified to have two separate board dts files that descend from the
common dtsi ancestor.

Having different amounts of DRAM on the same board design is present on
virtually all boards from other manufacturers, and some kind of special
DT treatment is needed only in some special cases, such as when different
types of DRAM are used for different capacities.

The different naming of the two board variants could be solved by having
something like this is the single board dts file:

  model = "OneThing OEC/OEC-turbo";

Having two separate board dts files only makes it harder down the road,
such as having to build and provide two separate U-Boot builds, with no
real benefits.  Every user can run free(1) to check the amount of available
DRAM on their board, which also tells them the board variant.