From: Marc Gonzalez <mgonzalez@freebox.fr>
To: Conor Dooley <conor@kernel.org>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
Arnaud Vrac <avrac@freebox.fr>,
Pierre-Hugues Husson <phhusson@freebox.fr>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: display: bridge: add TI TDP158
Date: Wed, 26 Jun 2024 19:20:46 +0200 [thread overview]
Message-ID: <d2012a93-911c-403e-b1c5-f01916a3200e@freebox.fr> (raw)
In-Reply-To: <20240626-blah-unseated-6cab234bae61@spud>
On 26/06/2024 18:08, Conor Dooley wrote:
> On Tue, Jun 25, 2024 at 06:38:12PM +0200, Marc Gonzalez wrote:
>
>> The TI TDP158 is an HDMI to TMDS Redriver.
>>
>> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
>> ---
>> .../bindings/display/bridge/ti,tdp158.yaml | 48 ++++++++++++++++++++++
>> 1 file changed, 48 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tdp158.yaml b/Documentation/devicetree/bindings/display/bridge/ti,tdp158.yaml
>> new file mode 100644
>> index 0000000000000..b687699e2ba80
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/ti,tdp158.yaml
>> @@ -0,0 +1,48 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/bridge/ti,tdp158.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: TI TDP158 HDMI to TMDS Redriver
>> +
>> +maintainers:
>> + - Arnaud Vrac <avrac@freebox.fr>
>> +
>> +properties:
>> + compatible:
>> + const: ti,tdp158
>> +
>> + reg:
>> + description: I2C address of the device
>> +
>> + enable-gpios:
>> + description: GPIO controlling bridge enable
>> +
>> + vcc-supply:
>> + description: Power supply 3.3V
>> +
>> + vdd-supply:
>> + description: Power supply 1.1V
>
> Are these supplies not also required? Surely the device needs the power
> to function?
Maybe if the hamsters spin fast enough in their wheels,
these supplies won't be required? :)
The reason I hesitated to mark them as required,
is because the HW engineer told us that on our board
they were connected to a power line that is shared
between several functional blocks.
I suppose that's not a reason?
Required means "device doesn't work if they're not connected" ?
Regards
next prev parent reply other threads:[~2024-06-26 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 16:38 [PATCH v2 0/2] Basic support for TI TDP158 Marc Gonzalez
2024-06-25 16:38 ` [PATCH v2 1/2] dt-bindings: display: bridge: add " Marc Gonzalez
2024-06-26 16:08 ` Conor Dooley
2024-06-26 17:20 ` Marc Gonzalez [this message]
2024-06-27 16:15 ` Conor Dooley
2024-06-27 7:24 ` Maxime Ripard
2024-06-25 16:38 ` [PATCH v2 2/2] drm/bridge: add support for " Marc Gonzalez
2024-06-26 4:47 ` Dmitry Baryshkov
2024-06-26 15:26 ` Marc Gonzalez
2024-06-26 16:23 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2012a93-911c-403e-b1c5-f01916a3200e@freebox.fr \
--to=mgonzalez@freebox.fr \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=avrac@freebox.fr \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=phhusson@freebox.fr \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).