From: Changhuang Liang <changhuang.liang@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Jack Zhu <jack.zhu@starfivetech.com>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx
Date: Thu, 4 May 2023 09:21:41 +0800 [thread overview]
Message-ID: <d2044dc1-ff5c-7398-5646-1bfdfb8ea935@starfivetech.com> (raw)
In-Reply-To: <31c582a7-682a-330e-51d4-53b4a0c5f3a2@linaro.org>
On 2023/4/17 1:29, Krzysztof Kozlowski wrote:
>>>> A standard property? Like "clocks" or "resets"?
>>>
>>> Like lane-polarities now submitted to one MIPI.
>>>
>>> Anyway it does not look like a property of a board. You said it is fixed
>>> per SoC, so it should be implied from the compatible. Otherwise please
>>> explain in description and provide some rationale.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> This property is the only one used for this IP, I have compared this IP with
>> other DPHY rx module, DPHY modules form the other manufacturers not have this
>> configure.
>> And we also have a SoC called JH7100. It DPHY rx module is the same as JH7110.
>> But we don't do the upstream work on it. If it use this lane-maps will be
>> configure as "lane_maps = /bits/ 8 <0 1 2 3 4 5>;".
>
> And JH7100 is different SoC, so you have different compatible. Again -
> is this board specific? If not, looks like SoC specific, thus imply it
> from compatible.
>
>
> Best regards,
> Krzysztof
>
Vinod,
Hi, could you give me some suggestions about Krzysztof's comment? Thanks for
your time.
Best regards,
Changhuang
next prev parent reply other threads:[~2023-05-04 1:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 8:45 [PATCH v4 0/3] Add JH7110 MIPI DPHY RX support Changhuang Liang
2023-04-12 8:45 ` [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx Changhuang Liang
2023-04-12 11:34 ` Krzysztof Kozlowski
2023-04-12 12:42 ` Changhuang Liang
2023-04-12 16:55 ` Krzysztof Kozlowski
2023-04-13 1:29 ` Changhuang Liang
2023-04-13 2:34 ` Changhuang Liang
2023-04-13 8:41 ` Krzysztof Kozlowski
2023-04-13 9:02 ` Changhuang Liang
2023-04-16 17:29 ` Krzysztof Kozlowski
2023-04-17 3:37 ` Changhuang Liang
2023-05-04 1:21 ` Changhuang Liang [this message]
2023-04-18 18:42 ` Rob Herring
2023-04-18 18:46 ` Rob Herring
2023-04-19 6:10 ` Changhuang Liang
2023-04-12 8:45 ` [PATCH v4 2/3] phy: starfive: Add mipi dphy rx support Changhuang Liang
2023-04-12 8:45 ` [PATCH v4 3/3] riscv: dts: starfive: Add dphy rx node Changhuang Liang
2023-05-22 13:00 ` [PATCH v4 0/3] Add JH7110 MIPI DPHY RX support Changhuang Liang
2023-05-22 13:11 ` Conor Dooley
2023-05-23 1:02 ` Changhuang Liang
2023-05-23 5:13 ` Conor Dooley
2023-05-23 5:54 ` Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2044dc1-ff5c-7398-5646-1bfdfb8ea935@starfivetech.com \
--to=changhuang.liang@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jack.zhu@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).