From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AAFCEB64D9 for ; Tue, 27 Jun 2023 20:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231455AbjF0Uq1 (ORCPT ); Tue, 27 Jun 2023 16:46:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230373AbjF0Uq0 (ORCPT ); Tue, 27 Jun 2023 16:46:26 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44DF71BC8 for ; Tue, 27 Jun 2023 13:46:25 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4fa48b5dc2eso5299961e87.1 for ; Tue, 27 Jun 2023 13:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687898783; x=1690490783; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7OJ43xoUAaQ7/BbXqVAEGUSQDP14HiDVf0qfii8I1YQ=; b=WeHGCh41l5qr7LA+qBes0VVFE2IEvDQx0TD2zppJTkpigfMtHqJ5DjO4nunlnyYAgN e7vknMZlOTubu/M7Blxui2QEPnnQsGe/6jOwFGV2AysHqLnjlOabVKf2agqR6i3HAjwk qkK6vwq79TQ2JClNzXotgp2cV3TVry7fgaXCm+nawyWONuTgmX5+lXG3Yo4Bf9jCbJlW 1h5afWMCvkfs07bZ/x4BuK04FTjOv+3h90pdNFyn7jeQMSdrc1HtujiIJWP8lDALyAjC 1xcynJDR8n3tasM+7zBtMZu4d7pnUGoi69i2N8y9u9eTGkucjIVz+vqfFM7Kyuq18eM0 FU1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687898783; x=1690490783; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7OJ43xoUAaQ7/BbXqVAEGUSQDP14HiDVf0qfii8I1YQ=; b=VAdjfxre9gkRdSpClQMBOQtpLxo9ga3KF+kw2EeCPXySf+zOW0hDLP2jb6ZOWZiPUn /bgGBtqooleFxo2Gm0pmMWDMJ7FOa3yd82xEsZSti5yqzl26IoCX1+mHfvW2bHW80goW vbHnHbtsXO6ReY3QIJRS8yyB2oy1z38HlI/fKHRUe97Oo3lBwVx6ZvBa99TJaotELyrf BC5xdi1PbM3GlBcr4GPovo+xBi3pXzPu8gVseXpPbXyHXFZJNr5xrvVVfcArrXMj2gne 7rYImkTAmEuR78uUPrOt+7kfzdbcSbBx5hbGW/cbbHkovYfK9d+60RENvyMDyiwp7NN8 GwtA== X-Gm-Message-State: AC+VfDwDdpNmF+gwdWLjsjhEXhu4O5YDKL7WmOeRC03ocrQusQR9FGsh 8E9UGC66TMzrGHTjdOUdvYuAug== X-Google-Smtp-Source: ACHHUZ5emIXmf1rO07fQAxgUi9BjGsQQr+Z1m68cQ3h8Fv+spImuqKnVYk5Ko6yRkLs2vijoGtJRQQ== X-Received: by 2002:a19:2d5b:0:b0:4f8:5e49:c613 with SMTP id t27-20020a192d5b000000b004f85e49c613mr17229826lft.43.1687898783459; Tue, 27 Jun 2023 13:46:23 -0700 (PDT) Received: from [192.168.1.101] (abxj103.neoplus.adsl.tpnet.pl. [83.9.3.103]) by smtp.gmail.com with ESMTPSA id eo7-20020a056512480700b004f86c43d615sm1670680lfb.295.2023.06.27.13.46.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 13:46:23 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 22:46:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 11/15] drm/msm/dsi: Reuse QCM2290 14nm DSI PHY configuration for SM6125 Content-Language: en-US To: Marijn Suijten , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Krishna Manikandan , Loic Poulain , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Lux Aliaga References: <20230627-sm6125-dpu-v2-0-03e430a2078c@somainline.org> <20230627-sm6125-dpu-v2-11-03e430a2078c@somainline.org> From: Konrad Dybcio In-Reply-To: <20230627-sm6125-dpu-v2-11-03e430a2078c@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27.06.2023 22:14, Marijn Suijten wrote: > SM6125 features only a single PHY (despite a secondary PHY PLL source > being available to the disp_cc_mdss_pclk0_clk_src clock), and downstream > sources for this "trinket" SoC do not define the typical "vcca" > regulator to be available nor used. This, including the register offset > is identical to QCM2290, whose config struct can trivially be reused. > > Signed-off-by: Marijn Suijten > --- Reviewed-by: Konrad Dybcio Konrad > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > index 9d5795c58a98..05621e5e7d63 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > @@ -561,6 +561,8 @@ static const struct of_device_id dsi_phy_dt_match[] = { > .data = &dsi_phy_14nm_660_cfgs }, > { .compatible = "qcom,dsi-phy-14nm-8953", > .data = &dsi_phy_14nm_8953_cfgs }, > + { .compatible = "qcom,sm6125-dsi-phy-14nm", > + .data = &dsi_phy_14nm_2290_cfgs }, > #endif > #ifdef CONFIG_DRM_MSM_DSI_10NM_PHY > { .compatible = "qcom,dsi-phy-10nm", >