From: Krzysztof Kozlowski <krzk@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>,
amitsd@google.com, "Sebastian Reichel" <sre@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lee Jones" <lee@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Badhri Jagan Sridharan" <badhri@google.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
RD Babiera <rdbabiera@google.com>, Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH 4/6] mfd: max77759: modify irq configs
Date: Mon, 24 Nov 2025 08:39:25 +0100 [thread overview]
Message-ID: <d2184e6b-ba22-423a-8d3c-3b8c2f8ec329@kernel.org> (raw)
In-Reply-To: <5c901a6c831775a04924880cc9f783814f75b6aa.camel@linaro.org>
On 24/11/2025 07:21, André Draszik wrote:
>
>> if (ret)
>> return dev_err_probe(&client->dev, ret,
>> "MAX77759_MAXQ_INT_APCMDRESI failed\n");
>> @@ -633,7 +643,7 @@ static int max77759_probe(struct i2c_client *client)
>> return dev_err_probe(&client->dev, -EINVAL,
>> "invalid IRQ: %d\n", client->irq);
>>
>> - irq_flags = IRQF_ONESHOT | IRQF_SHARED;
>> + irq_flags = IRQF_ONESHOT | IRQF_SHARED | IRQF_TRIGGER_LOW;
>
> I don't believe IRQF_TRIGGER_LOW should be added here, as this is board-specific.
> The polarity is meant to be set via DT (and the only current user of this driver
> does so).
>
If this is the main chip interrupt, then you are right and the code is
obviously wrong. What's more, it is completely unexplained in the commit
msg, because that vague statement cannot be taken as any reasonable
explanation.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-24 7:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-23 8:35 [PATCH 0/6] Introduce MAX77759 charger driver Amit Sunil Dhamne via B4 Relay
2025-11-23 8:35 ` [PATCH 1/6] dt-bindings: power: supply: Add Maxim MAX77759 charger Amit Sunil Dhamne via B4 Relay
2025-11-23 9:28 ` Krzysztof Kozlowski
2025-11-24 2:34 ` Amit Sunil Dhamne
2025-11-25 9:56 ` Krzysztof Kozlowski
2025-11-25 23:48 ` Amit Sunil Dhamne
2025-12-02 13:00 ` Krzysztof Kozlowski
2025-12-04 21:06 ` Amit Sunil Dhamne
2025-11-23 8:35 ` [PATCH 2/6] dt-bindings: mfd: maxim,max77759: add charger child node Amit Sunil Dhamne via B4 Relay
2025-11-23 9:30 ` Krzysztof Kozlowski
2025-11-26 0:02 ` Amit Sunil Dhamne
2025-11-23 8:35 ` [PATCH 3/6] dt-bindings: usb: maxim,max33359: Add supply property for VBUS in OTG mode Amit Sunil Dhamne via B4 Relay
2025-11-24 7:53 ` Krzysztof Kozlowski
2025-11-25 20:13 ` Amit Sunil Dhamne
2025-11-26 16:18 ` André Draszik
2025-11-26 20:27 ` Amit Sunil Dhamne
2025-11-26 10:01 ` Heikki Krogerus
2025-11-26 20:50 ` Amit Sunil Dhamne
2025-11-23 8:35 ` [PATCH 4/6] mfd: max77759: modify irq configs Amit Sunil Dhamne via B4 Relay
2025-11-24 6:21 ` André Draszik
2025-11-24 7:39 ` Krzysztof Kozlowski [this message]
2025-11-26 1:19 ` Amit Sunil Dhamne
2025-11-26 1:10 ` Amit Sunil Dhamne
2025-11-26 6:44 ` André Draszik
2025-11-26 7:36 ` André Draszik
2025-11-27 4:15 ` Amit Sunil Dhamne
2025-11-24 7:38 ` Krzysztof Kozlowski
2025-11-23 8:35 ` [PATCH 5/6] power: supply: max77759: add charger driver Amit Sunil Dhamne via B4 Relay
2025-11-26 7:36 ` André Draszik
2025-11-26 7:38 ` kernel test robot
2025-11-26 22:04 ` Amit Sunil Dhamne
2025-11-23 8:35 ` [PATCH 6/6] usb: typec: tcpm/tcpci_maxim: deprecate WAR for setting charger mode Amit Sunil Dhamne via B4 Relay
2025-11-24 9:09 ` André Draszik
2025-11-26 2:32 ` Amit Sunil Dhamne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2184e6b-ba22-423a-8d3c-3b8c2f8ec329@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=amitsd@google.com \
--cc=andre.draszik@linaro.org \
--cc=badhri@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=kyletso@google.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=rdbabiera@google.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).