From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings Date: Wed, 8 May 2019 05:52:16 +0200 Message-ID: References: <1556092536-17095-1-git-send-email-masonccyang@mxic.com.tw> <1556092536-17095-4-git-send-email-masonccyang@mxic.com.tw> <20190424212356.GA27103@bogus> <65853dc2-6f3c-1494-7e72-54877797cdd2@gmail.com> <20190507125730.GD29524@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: masonccyang@mxic.com.tw, Lee Jones Cc: bbrezillon@kernel.org, broonie@kernel.org, devicetree@vger.kernel.org, Geert Uytterhoeven , Simon Horman , juliensu@mxic.com.tw, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-spi@vger.kernel.org, mark.rutland@arm.com, Rob Herring , sergei.shtylyov@cogentembedded.com, zhengxunli@mxic.com.tw List-Id: devicetree@vger.kernel.org On 5/8/19 4:48 AM, masonccyang@mxic.com.tw wrote: > Hi Jones, > >> "Lee Jones" >> 2019/05/07 下午 08:58 >> >> To >> >> "Marek Vasut" , >> >> cc >> >> "Rob Herring" , "Mason Yang" >> , broonie@kernel.org, linux- >> kernel@vger.kernel.org, linux-spi@vger.kernel.org, >> bbrezillon@kernel.org, linux-renesas-soc@vger.kernel.org, "Geert >> Uytterhoeven" , >> sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com, >> devicetree@vger.kernel.org, juliensu@mxic.com.tw, "Simon Horman" >> , zhengxunli@mxic.com.tw >> >> Subject >> >> Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 >> RPC-IF MFD bindings >> >> On Wed, 24 Apr 2019, Marek Vasut wrote: >> >> > On 4/24/19 11:23 PM, Rob Herring wrote: >> > > On Wed, Apr 24, 2019 at 03:55:36PM +0800, Mason Yang wrote: >> > >> Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD. >> > >> >> > >> Signed-off-by: Mason Yang >> > >> --- >> > >>  .../devicetree/bindings/mfd/mfd-renesas-rpc.txt    | 40 ++++++ >> ++++++++++++++++ >> > >>  1 file changed, 40 insertions(+) >> > >>  create mode 100644 Documentation/devicetree/bindings/mfd/mfd- >> renesas-rpc.txt >> > >> >> > >> diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas- >> rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt >> > >> new file mode 100644 >> > >> index 0000000..668b822 >> > >> --- /dev/null >> > >> +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt >> > >> @@ -0,0 +1,40 @@ >> > >> +Renesas R-Car Gen3 RPC-IF MFD Device Tree Bindings >> > >> +-------------------------------------------------- >> > > >> > > Looks like a SPI flash controller from the example. What makes it an >> > > MFD? >> > >> > It supports both SPI NOR and HyperFlash (CFI-compliant flash with >> > different bus interface). >> >> Looks like you're registering one OR the other. >> >> Why don't you just do this from DT? >> >> No reason for this to be an MFD IMHO. > > > okay, I will patch it back to SPI mode only. I don't think that's what Lee meant . The controller supports _both_ modes , hence it would have the same compatible string. You just need to extract the mode of operation from the DT. -- Best regards, Marek Vasut