From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E93D6C54EE9 for ; Tue, 13 Sep 2022 17:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233199AbiIMRgN (ORCPT ); Tue, 13 Sep 2022 13:36:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233129AbiIMRfz (ORCPT ); Tue, 13 Sep 2022 13:35:55 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DCF8985B9 for ; Tue, 13 Sep 2022 09:25:52 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id bd26-20020a05600c1f1a00b003a5e82a6474so9840706wmb.4 for ; Tue, 13 Sep 2022 09:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=OKN8VlLuCDfiERxzI2+XM2BCjDBYdD0WSU7txH+oqhI=; b=uRznjyTYGrqXpXwIJzlmIXQ25Hr8qtCVtmJMwp9zvx6YIJSIMRaU/ApNl1dXzKSlzW 0w7L46c0OJH/XxX4AhBDD787JHuoELtjuw9GFV9TNVSpTtMqjE2hv11kLsWh4x9lJi46 GCI5qDKHEkgq4wIkv4LFBTQI8XgOvZYLVUFBLgWQzJCfybmM2/c1yr8tmNZNt2mLTmp/ iKydIWrpBpYUJ+jbpPurldzcH6O58vXw8ZTyBiewsQf14tYfyG6fMDeVgjC+RPcNh+rp jEJ3MltDE1TvhrOtSyl7FwOIzXHqyx/zOI8df8TiE70WlsO1W5jz5FY2Gp1JnQFMpyFt bVWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=OKN8VlLuCDfiERxzI2+XM2BCjDBYdD0WSU7txH+oqhI=; b=xpMHqp5Kbe2qwhna2aOh6txKJ9QiJLJ70KTSSKiz9se+CKyqH9MG5uzq/TjjwdaTox YkUP027jT59KoRWPDomFrmPMWMVgzqVqp1eEGWXZ1+OFDiIoZUmUaY/V3j5ohPNYJzU/ FGuh6fD+pW3f/jeokXvYdANz9+osywMHYWOcegXhYLPkQZjIFxeZSWXlDAu/+k1J6jI+ jziA1AX83sH3Lr1JKNRTfWZDzt2ODFK1I5a0Ty19Hx5zPs/o89Hxny6DOKe+0yBKEjD5 XTHWm1SwShSfH2gXoDy63qleSklTtZFdGXydTK/TxkFQblKSB/RflsyphhUS88pt2CtO 5fJQ== X-Gm-Message-State: ACgBeo2+LUEc2Jm10dnHbxIr1QQnS2LGm2189faCxILqtMF0epU2fYnd nFhZJ/0ltHj5hlZgzMaQAkLQKQ== X-Google-Smtp-Source: AA6agR6m+cKtfWYfmOldGwLugLA9gLJ2qT8xWuOhJD/1NmvBke6ThGWFcraQyfDokvJeknozSLV1tg== X-Received: by 2002:a7b:c84f:0:b0:3b4:84c1:1e7 with SMTP id c15-20020a7bc84f000000b003b484c101e7mr125429wml.12.1663086351164; Tue, 13 Sep 2022 09:25:51 -0700 (PDT) Received: from [10.119.22.201] ([89.101.193.68]) by smtp.gmail.com with ESMTPSA id i12-20020a1c540c000000b003b47ff3807fsm9364257wmb.5.2022.09.13.09.25.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Sep 2022 09:25:50 -0700 (PDT) Message-ID: Date: Tue, 13 Sep 2022 18:25:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] dt-bindings: pci: qcom,pcie-ep: correct qcom,perst-regs Content-Language: en-US To: Rob Herring Cc: Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Konrad Dybcio , Bjorn Helgaas , Krzysztof Kozlowski , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam References: <20220911135547.23106-1-krzysztof.kozlowski@linaro.org> <11e61fa5-f770-9c9f-23b9-3d1dcb205bc5@linaro.org> <20220913152054.GA3736444-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220913152054.GA3736444-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/09/2022 17:20, Rob Herring wrote: > On Sun, Sep 11, 2022 at 04:14:54PM +0200, Krzysztof Kozlowski wrote: >> On 11/09/2022 15:55, Krzysztof Kozlowski wrote: >>> qcom,perst-regs is an phandle array of one item with a phandle and its >>> arguments. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 6 ++++-- >>> 1 file changed, 4 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >>> index 3d23599e5e91..077e002b07d3 100644 >>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >>> @@ -60,8 +60,10 @@ properties: >>> enable registers >>> $ref: "/schemas/types.yaml#/definitions/phandle-array" >>> items: >>> - minItems: 3 >>> - maxItems: 3 >>> + - items: >>> + - description: Syscon to TCSR system registers >>> + - description: Perst enable offset >>> + - description: Perst separateion enable offset >> >> Unfortunately this still complains: >> >> qcom-sdx55-t55.dtb: pcie-ep@40000000: qcom,perst-regs:0: [28] is too short >> >> >> where 28 is the phandle... > > Meaning the dt is wrong or there's a tooling issue? I think tooling issue. I looked at this many times and code (schema and DTS) seems to be correct, but tool doesn't like it. Best regards, Krzysztof