From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B769C7EE2E for ; Mon, 12 Jun 2023 08:16:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229565AbjFLIQz (ORCPT ); Mon, 12 Jun 2023 04:16:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbjFLIQu (ORCPT ); Mon, 12 Jun 2023 04:16:50 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DD9291 for ; Mon, 12 Jun 2023 01:16:45 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9768fd99c0cso1057868566b.0 for ; Mon, 12 Jun 2023 01:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686557804; x=1689149804; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=81HGPWtAHcoj4MGq+asBDEpD8CKCjuMMVkQmG5qPgmg=; b=YPOZhtA7hANwDQUmlXvVMP4eb9WKXMhJDY0KJUr9vJ7FLEbEMApwJKEXFoR1k2qUZL uobhy/NjWgItNWdbzJ3WvKtks6fjR/cYgvaFQN28o85JTVx934rieLglxJbw6jQgcHlN du8vBMGl55LFgsPDS5GMhlMySjIDq7lSI4oyd7v8ACvp+A/xDn9doI1oV/BHPgJj0VPa JuloBQ6e7HtRyRS/Zrw3YMppdNAZvTDgMmiiwCZdK00JSBGUis/JvauWDwX6zPh/OFvU gHNkO7HVkZq4gbTWP3MQm4hkNj1N1ZFQv4ARRKtOPQ1FMERdFIXs76gD91WyTcpDHM5O OyQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686557804; x=1689149804; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=81HGPWtAHcoj4MGq+asBDEpD8CKCjuMMVkQmG5qPgmg=; b=gasZyC3QwmTeKNOKW3fyQnyYO399uxe4ndHqNMhO/li237wAolGMMfAlaMXwJMZEbR ozusyY1kJDxzSoq/HK3CeiiQMT4HBzTHb367s2OBwqYr6ju9d+97NBdUI2q2uXoX1rzp zjkeVBw7maVQRSv3eoqAhQtDbbQq7PYilgUBXI10hCwrmP/SagR/PU/3mx6YYh0noJhV 2O9YI3w8l33N4rEhxmUfS/ACZiX6jVJVL6u5wr4gI2WGEvQK+N+qbKIhMLrQUCVfqHey OfVYPMnKTpVm/7ijbTE6x+R6tx7C1TLY1nfl9ON0TkxUTF9P61yQidjccevKWfeAORPT m7Iw== X-Gm-Message-State: AC+VfDwayNPfJO1rl5ysTnrAWA1or4dZGfUSPOoIW/f15l2lkrBg5rhM nIMxmisTmLzGFlT35fEtT5szNONNYyml/jsuxRY= X-Google-Smtp-Source: ACHHUZ4/9kW8EA3qDwmtmg1KAWHGBhqtlbWwrnPt1f23DTverEEj1APChP1sjDuvSV9n4bHt5r6e6Q== X-Received: by 2002:a17:907:6d16:b0:96f:a412:8b03 with SMTP id sa22-20020a1709076d1600b0096fa4128b03mr8239353ejc.5.1686557804177; Mon, 12 Jun 2023 01:16:44 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id fi5-20020a170906da0500b00965d294e633sm4867694ejb.58.2023.06.12.01.16.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 01:16:43 -0700 (PDT) Message-ID: Date: Mon, 12 Jun 2023 10:16:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v12 1/2] spi: add loongson spi bindings To: zhuyinbo , Mark Brown , Rob Herring , Krzysztof Kozlowski , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn References: <20230608072819.25930-1-zhuyinbo@loongson.cn> <20230608072819.25930-2-zhuyinbo@loongson.cn> <6ebed84c-2b42-c981-7b3f-e71cc88e4c2c@linaro.org> <4bf747c4-b767-b20c-e00f-724b50f44edb@loongson.cn> <6bfc2a22-6901-0858-7b90-bc4c52c66810@linaro.org> <11ca2b90-544d-18c2-fb15-7909ca60507f@linaro.org> <9c94397d-1e31-02fa-bdbe-af888c72eac4@loongson.cn> <657f8d19-de83-8be6-4a9d-5f13b1df7383@linaro.org> <84ccf4cc-072d-adbf-0361-95ceae13f333@linaro.org> <5d060cac-ff28-60e9-98a8-f2bd4d378455@loongson.cn> <4e30870d-86e2-8536-8e0d-aab4ce5027d2@linaro.org> <0c532e09-4821-5e07-92e6-7bc3cd79869e@loongson.cn> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <0c532e09-4821-5e07-92e6-7bc3cd79869e@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/06/2023 09:40, zhuyinbo wrote: > > > 在 2023/6/12 下午3:17, Krzysztof Kozlowski 写道: >> On 12/06/2023 09:13, zhuyinbo wrote: >>> >>> >>> 在 2023/6/10 上午12:45, Krzysztof Kozlowski 写道: >>>> On 09/06/2023 05:13, zhuyinbo wrote: >>>>> >>>>> >>>>> 在 2023/6/8 下午9:26, Krzysztof Kozlowski 写道: >>>>>> On 08/06/2023 14:10, zhuyinbo wrote: >>>>>>> >>>>>>> >>>>>>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道: >>>>>>>> On 08/06/2023 13:42, zhuyinbo wrote: >>>>>>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>>>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>>>>>>>> @@ -16,6 +16,7 @@ properties: >>>>>>>>> compatible: >>>>>>>>> enum: >>>>>>>>> - loongson,ls2k1000-spi >>>>>>>>> + - loongson,ls2k0500-spi >>>>>>>> >>>>>>>> Aren't they compatible? >>>>>>>> >>>>>>> >>>>>>> >>>>>>> Are you saying that the spi driver is compatible with 2k0500 ? >>>>>> >>>>>> Didn't you say this through 11 previous revisions? >>>>> >>>>> >>>>> Yes, did I understand your meaning incorrectly ? >>>> >>>> If they are compatible, then they are not part of one enum. They could >>>> not be as this would easily fail in testing of your DTS. >>>> >>> >>> >>> The "loongson,ls2k0500-spi" wasn't a compatible in previous version and >>> I will add "loongson,ls2k0500-spi" as a compatible in spi driver and >>> added it as a part of the one enum in dt-binding. >> >> No, because you claimed - if I understood correctly - that they are >> compatible. Don't add fake entries to the driver. >> > > > I'm a bit confused, and I just need to add 'loongson,ls2k0500-spi' as > one enum in dt-bindings, but driver don't add this entry ? Compatibility is expressed with a list: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#compatible so it cannot be just one enum, but "items". There are hundreds of examples including example-schema. Best regards, Krzysztof