From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: guoniu.zhou@oss.nxp.com, linux-media@vger.kernel.org,
linux-imx@nxp.com, devicetree@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, xavier.roumegue@oss.nxp.com,
kernel@pengutronix.de, jacopo.mondi@ideasonboard.com,
sakari.ailus@linux.intel.com
Subject: Re: [PATCH 1/4] media: dt-bindings: media: rename nxp,imx8-isi.yaml to nxp,imx-isi.yaml
Date: Sun, 25 Jun 2023 10:18:24 +0200 [thread overview]
Message-ID: <d26640a0-52f6-9a4a-404d-fb1b5223924f@linaro.org> (raw)
In-Reply-To: <20230625080916.3553621-2-guoniu.zhou@oss.nxp.com>
On 25/06/2023 10:09, guoniu.zhou@oss.nxp.com wrote:
> From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
>
> Rename nxp,imx8-isi.yaml to nxp,imx-isi.yaml since the binding doc will
> also be used in other i.MX SoC, such as i.MX9 serials.
Subject: you have too many "media:". One, first is enough.
>
> Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
> ---
> .../bindings/media/{nxp,imx8-isi.yaml => nxp,imx-isi.yaml} | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml
> similarity index 97%
> rename from Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
> rename to Documentation/devicetree/bindings/media/nxp,imx-isi.yaml
> index 6038b9b5ab36..1ce9440bde32 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml
> @@ -1,10 +1,10 @@
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/media/nxp,imx8-isi.yaml#
> +$id: http://devicetree.org/schemas/media/nxp,imx-isi.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: i.MX8 Image Sensing Interface
> +title: i.MX Image Sensing Interface
This patch by itself does not make sense. Could be squashed or just drop
it. No real reason for renaming.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-25 8:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 8:09 [PATCH 0/4] add ISI support for i.MX93 guoniu.zhou
2023-06-25 8:09 ` [PATCH 1/4] media: dt-bindings: media: rename nxp,imx8-isi.yaml to nxp,imx-isi.yaml guoniu.zhou
2023-06-25 8:18 ` Krzysztof Kozlowski [this message]
2023-06-25 8:09 ` [PATCH 2/4] media: nxp: rename imx8-isi to imx-isi and remove reference to i.MX8 guoniu.zhou
2023-06-25 8:28 ` Krzysztof Kozlowski
2023-06-25 8:09 ` [PATCH 3/4] media: dt-bindings: media: nxp,imx-isi: i.MX93 support guoniu.zhou
2023-06-25 8:22 ` Krzysztof Kozlowski
2023-06-25 8:27 ` Krzysztof Kozlowski
2023-06-27 14:20 ` Rob Herring
2023-06-25 8:28 ` G.N. Zhou (OSS)
2023-06-25 8:47 ` G.N. Zhou
2023-06-25 9:15 ` Krzysztof Kozlowski
2023-06-26 2:14 ` G.N. Zhou (OSS)
2023-06-25 8:09 ` [PATCH 4/4] media: nxp: imx-isi: add ISI support for i.MX93 guoniu.zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d26640a0-52f6-9a4a-404d-fb1b5223924f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoniu.zhou@oss.nxp.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=xavier.roumegue@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).