public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: <Balakrishnan.S@microchip.com>
To: <krzk@kernel.org>, <claudiu.beznea@tuxon.dev>,
	<Andrei.Simion@microchip.com>, <lgirdwood@gmail.com>,
	<broonie@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <Nicolas.Ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>
Cc: <linux-sound@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ASoC: dt-bindings: sound: atmel-at91sam9g20ek: convert to json-schema
Date: Thu, 12 Dec 2024 06:29:02 +0000	[thread overview]
Message-ID: <d26a9ea9-d6bc-460f-8c56-ef025459484a@microchip.com> (raw)
In-Reply-To: <0358a6ac-4037-444b-8e65-4e5afa29e8c3@kernel.org>

Hi Krzysztof,

On 11/12/24 4:59 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 11/12/2024 10:46, Balakrishnan Sambath wrote:
>> +properties:
>> +  compatible:
>> +    const: atmel,at91sam9g20ek-wm8731-audio
>> +
>> +  atmel,model:
>> +    $ref: /schemas/types.yaml#/definitions/string
>> +    description: The user-visible name of this sound complex.
>> +
>> +  atmel,audio-routing:
>> +    $ref: /schemas/types.yaml#/definitions/non-unique-string-array
>> +    description: A list of the connections between audio components.
>> +    items:
>> +      enum:
>> +        # Board Connectors
>> +        - Ext Spk
>> +        - Int Mic
>> +
>> +        # CODEC Pins
>> +        - LOUT
>> +        - ROUT
>> +        - LHPOUT
>> +        - RHPOUT
>> +        - LLINEIN
>> +        - RLINEIN
>> +        - MICIN
> 
> As previously questioned, I don't think you can create infinite amount
> of pairs out of it. Assuming you always connect board with codec
> (because codec-codec are already defined inside the codec), you can have
> max 14 pairs, but most likely less in practice.
I agree with your perspective.Here this binding is specific to the 
AT91SAM9G20EK board,which uses the onboard WM8731 codec for audio 
support.Since some of similar bindings do not explicitly enforce 
maxItems,I assumed this to be a valid case. However, based on my 
understanding from the schematics, 
https://ww1.microchip.com/downloads/en/DeviceDoc/doc6413.pdf, a 
"maxItems: 4" value appears valid.Are you referring to the same 
understanding here?
> 
> Best regards,
> Krzysztof

-- 
Best regards,
Balakrishnan S

  reply	other threads:[~2024-12-12  6:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11  9:46 [PATCH v2] ASoC: dt-bindings: sound: atmel-at91sam9g20ek: convert to json-schema Balakrishnan Sambath
2024-12-11 11:21 ` Rob Herring (Arm)
2024-12-11 11:29 ` Krzysztof Kozlowski
2024-12-12  6:29   ` Balakrishnan.S [this message]
2024-12-11 12:03 ` Andrei Simion

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d26a9ea9-d6bc-460f-8c56-ef025459484a@microchip.com \
    --to=balakrishnan.s@microchip.com \
    --cc=Andrei.Simion@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox