From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dzmitry Sankouski <dsankouski@gmail.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 4/6] arm64: dts: qcom: starqltechn: enable more features
Date: Sat, 28 Oct 2023 22:18:57 +0200 [thread overview]
Message-ID: <d26b9c61-00ae-4149-aae8-ab528007d96b@linaro.org> (raw)
In-Reply-To: <CABTCjFA4Y5o8S+JUh=9h3zHo2VCRJCejabs_UAkn=n1WUnYK3A@mail.gmail.com>
On 28/10/2023 19:13, Dzmitry Sankouski wrote:
> ...
>>> +
>>> + touchscreen@48 {
>>> + compatible = "samsung,s6sy761";
>>> + reg = <0x48>;
>>> + interrupt-parent = <&tlmm>;
>>> + interrupts = <120 0x0>;
>> interrupts-extended with a fixed irq type (not _NONE)
>>
> Can you please explain why not _NONE?
> Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.txt example
> says it should be IRQ_TYPE_NONE.
I don't see the binding saying this And just to be clear: example,
especially incorrect example, means nothing.
There are no hardware interrupts of type NONE. That's why you should not
use it, It just does not exist.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-28 20:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231024154338.407191-1-dsankouski@gmail.com>
2023-10-24 15:43 ` [PATCH v2 1/6] dt-bindings: regulator: add Samsung s2dos05 pmic Dzmitry Sankouski
2023-10-24 15:59 ` Krzysztof Kozlowski
2023-10-28 16:01 ` Dzmitry Sankouski
2023-10-28 20:17 ` Krzysztof Kozlowski
2023-10-29 12:06 ` Dzmitry Sankouski
2023-10-24 16:29 ` Rob Herring
2023-10-24 15:43 ` [PATCH v2 3/6] arm64: dts: qcom: starqltechn: remove wifi Dzmitry Sankouski
2023-10-24 22:04 ` Bryan O'Donoghue
2023-10-26 19:21 ` Konrad Dybcio
2023-10-24 15:43 ` [PATCH v2 4/6] arm64: dts: qcom: starqltechn: enable more features Dzmitry Sankouski
2023-10-26 19:26 ` Konrad Dybcio
2023-10-28 17:13 ` Dzmitry Sankouski
2023-10-28 20:18 ` Krzysztof Kozlowski [this message]
2023-10-24 15:43 ` [PATCH v2 5/6] arm64: dts: qcom: starqltechn: disable crypto Dzmitry Sankouski
2023-10-24 22:09 ` Bryan O'Donoghue
2023-10-26 19:33 ` Konrad Dybcio
2023-10-24 15:43 ` [PATCH v2 6/6] arm64: dts: qcom: starqltechn: add supply to framebuffer Dzmitry Sankouski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d26b9c61-00ae-4149-aae8-ab528007d96b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsankouski@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).